Merge branch 'main' of https://github.com/Azure/azure-sdk-for-net into sofiar/mobile_changes

Author: sofiar-msft

.github/workflows/copilot-setup-steps.yml

@@ -0,0 +1,38 @@
+name: "Copilot Setup Steps"
+
+# Automatically run the setup steps when they are changed to allow for easy validation, and
+# allow manual testing through the repository's "Actions" tab
+on:
+  workflow_dispatch:
+  push:
+    paths:
+      - .github/workflows/copilot-setup-steps.yml
+  pull_request:
+    paths:
+      - .github/workflows/copilot-setup-steps.yml
+
+jobs:
+  # The job MUST be called `copilot-setup-steps` or it will not be picked up by Copilot.
+  copilot-setup-steps:
+    runs-on: ubuntu-latest
+
+    # Set the permissions to the lowest permissions possible needed for your steps.
+    # Copilot will be given its own token for its operations.
+    permissions:
+      # If you want to clone the repository as part of your setup steps, for example to install dependencies, you'll need the `contents: read` permission. If you don't clone the repository in your setup steps, Copilot will do this for you automatically after the steps complete.
+      contents: read
+
+    # You can define any steps you want, and they will run before the agent starts.
+    # If you do not check out your code, Copilot will do this for you.
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Setup .NET
+        uses: actions/setup-dotnet@v4
+        with:
+          dotnet-version: 9.0.x
+
+      # Example: Display .NET SDK version
+      - name: Show .NET SDK version
+        run: dotnet --version

.vscode/cspell.json

@@ -1728,6 +1728,23 @@
         "prebuilts"
       ]
     },
+    {
+      "filename": "**/sdk/healthinsights/Azure.Health.Insights.RadiologyInsights/**",
+      "words": [
+        "Ceus",
+        "Tonnis",
+        "Hnpcc",
+        "Ascvd",
+        "Mednax",
+        "Cusick",
+        "Acrad",
+        "Kellgren",
+        "Frax",
+        "Birads",
+        "Agatston",
+        "Tyrer"
+      ]
+    },
     {
       "filename": "**/sdk/iotoperations/Azure.ResourceManager.IotOperations/api/*.cs",
       "words": [

eng/Directory.Build.Common.props

@@ -31,6 +31,7 @@
 
   <!-- Setup default project properties -->
   <PropertyGroup>
+    <LtsTargetFramework>net8.0</LtsTargetFramework>
     <LangVersion>latest</LangVersion>
     <!--
       Disable NU5105 NuGet Pack warning that the version is SemVer 2.0.
@@ -108,7 +109,7 @@
     <GenerateAPIListing Condition="'$(GenerateAPIListing)' == '' AND '$(IsShippingClientLibrary)' == 'true'">true</GenerateAPIListing>
     <EnableSourceLink Condition="'$(EnableSourceLink)' == ''">true</EnableSourceLink>
     <DefineConstants Condition="'$(BuildSnippets)' == 'true'">$(DefineConstants);SNIPPET</DefineConstants>
-    <ApiCompatBaselineTargetFramework Condition="'$(TargetFramework)' == 'net8.0'">netstandard2.0</ApiCompatBaselineTargetFramework>
+    <ApiCompatBaselineTargetFramework Condition="'$(TargetFramework)' == '$(LtsTargetFramework)'">netstandard2.0</ApiCompatBaselineTargetFramework>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(IsShippingClientLibrary)' == 'true' and '$(TF_BUILD)' == 'true'">
@@ -139,15 +140,15 @@
     <SupportsNetStandard20 Condition="'$(SupportsNetStandard20)' == ''">false</SupportsNetStandard20>
 
     <RequiredTargetFrameworks>net452;net461;netstandard2.0</RequiredTargetFrameworks>
-    <RequiredTargetFrameworks Condition="'$(SupportsNetStandard20)' == 'true' and '$(IsSourceGenerator)' != 'true'">net8.0;netstandard2.0</RequiredTargetFrameworks>
-    <RequiredTargetFrameworks Condition="'$(IsGeneratorLibrary)' == 'true'">net8.0</RequiredTargetFrameworks>
+    <RequiredTargetFrameworks Condition="'$(SupportsNetStandard20)' == 'true' and '$(IsSourceGenerator)' != 'true'">$(LtsTargetFramework);netstandard2.0</RequiredTargetFrameworks>
+    <RequiredTargetFrameworks Condition="'$(IsGeneratorLibrary)' == 'true'">$(LtsTargetFramework)</RequiredTargetFrameworks>
     <RequiredTargetFrameworks Condition="'$(IsSourceGenerator)' == 'true'">netstandard2.0</RequiredTargetFrameworks>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(IsGeneratorLibrary)' != 'true' and ('$(IsTestProject)' == 'true' or '$(IsTestSupportProject)' == 'true' or '$(IsSamplesProject)' == 'true' or '$(IsPerfProject)' == 'true' or '$(IsStressProject)' == 'true')">
     <IsPackable>false</IsPackable>
     <!-- List newest targets first so that recordings are made with latest, running tests from editor runs latest, etc. -->
-    <RequiredTargetFrameworks>net9.0;net8.0;</RequiredTargetFrameworks>
+    <RequiredTargetFrameworks>net9.0;$(LtsTargetFramework);</RequiredTargetFrameworks>
     <!-- Also test net462 on Windows. net461 is out of support as of 4/2022 and is not supported in version 4.4.x and beyond of NUnit3TestAdapter. -->
     <RequiredTargetFrameworks Condition="'$(OS)' == 'Windows_NT'">$(RequiredTargetFrameworks);net462</RequiredTargetFrameworks>
     <!-- But only build snippets for the latest. -->

eng/Directory.Build.Common.targets

@@ -364,7 +364,7 @@
   <Target Name="RunApiCompat" DependsOnTargets="ValidateApiCompatForSrc" Condition="'$(ApiCompatVersion)' != ''">
   </Target>
 
-  <Target Name="GetPackageInfo">
+  <Target Name="GetPackageInfo" Returns="@(PackageInfoLine)">
     <PropertyGroup>
       <PackageIsNewSdk>false</PackageIsNewSdk>
       <PackageIsNewSdk Condition="'$(IsClientLibrary)' == 'true' or '$(IsFunctionsLibrary)' == 'true'">true</PackageIsNewSdk>
@@ -380,9 +380,14 @@
 
       <!-- Parse out the service directory based on the relative path to the sdk folder -->
       <ServiceDirectory><![CDATA[$([System.Text.RegularExpressions.Regex]::Replace($(PackageRootDirectory), '^.*[\\/]+sdk[\\/]+([^\\/]+).*$', '$1'))]]></ServiceDirectory>
+      
+      <!-- Format package info line for output -->
+      <PackageInfoText Condition="'$(IsShippingLibrary)' == 'true'">'$(PackageRootDirectory)' '$(ServiceDirectory)' '$(PackageId)' '$(VersionForProperties)' '$(PackageSdkType)' '$(PackageIsNewSdk)' '$(BaseOutputPath)'</PackageInfoText>
     </PropertyGroup>
 
-    <Message Condition="'$(IsShippingLibrary)' == 'true'" Text="'$(PackageRootDirectory)' '$(ServiceDirectory)' '$(PackageId)' '$(VersionForProperties)' '$(PackageSdkType)' '$(PackageIsNewSdk)' '$(BaseOutputPath)'" Importance="High" />
+    <ItemGroup Condition="'$(IsShippingLibrary)' == 'true'">
+      <PackageInfoLine Include="$(PackageInfoText)" />
+    </ItemGroup>
   </Target>
 
   <Target Name="GetCodeGenProjects" Returns="@(ProjectsToInclude)">

eng/Packages.Data.props

@@ -120,7 +120,7 @@
     <PackageReference Update="Azure.Messaging.EventHubs" Version="5.12.1" />
     <PackageReference Update="Azure.Messaging.EventGrid" Version="4.21.0" />
     <PackageReference Update="Azure.Messaging.EventGrid.SystemEvents" Version="1.0.0-beta.5" />
-    <PackageReference Update="Azure.Messaging.ServiceBus" Version="7.19.0" />
+    <PackageReference Update="Azure.Messaging.ServiceBus" Version="7.20.1" />
     <PackageReference Update="Azure.Messaging.WebPubSub" Version="1.4.0" />
     <PackageReference Update="Azure.MixedReality.Authentication" version= "1.2.0" />
     <PackageReference Update="Azure.Monitor.OpenTelemetry.Exporter" Version="1.4.0" />
@@ -243,7 +243,7 @@
     <PackageReference Update="Microsoft.AspNetCore.Http" Version="2.3.0" />
     <PackageReference Update="Microsoft.AspNetCore.Http.Connections" Version="1.2.0" />
     <PackageReference Update="Microsoft.Azure.Functions.Worker.Extensions.Abstractions" Version="1.3.0" />
-    <PackageReference Update="Microsoft.Extensions.Azure" Version="1.8.0" />
+    <PackageReference Update="Microsoft.Extensions.Azure" Version="1.12.0" />
     <PackageReference Update="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.2" />
     <PackageReference Update="Microsoft.Extensions.Configuration" Version="8.0.0" />
     <PackageReference Update="Microsoft.Extensions.Configuration.Abstractions" Version="8.0.0" />
@@ -307,7 +307,7 @@
     <PackageReference Update="Azure.Identity" Version="1.14.0" />
     <PackageReference Update="Azure.Messaging.EventGrid" Version="4.17.0" />
     <PackageReference Update="Azure.Messaging.EventHubs.Processor" Version="5.12.0" />
-    <PackageReference Update="Azure.Messaging.ServiceBus" Version="7.19.0" />
+    <PackageReference Update="Azure.Messaging.ServiceBus" Version="7.20.1" />
     <PackageReference Update="Azure.ResourceManager" Version="1.13.0" />
     <PackageReference Update="Azure.ResourceManager.Compute" Version="1.9.0" />
     <PackageReference Update="Azure.ResourceManager.CognitiveServices" Version="1.3.0" />
@@ -377,7 +377,7 @@
     <PackageReference Update="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.8.0" />
     <PackageReference Update="Microsoft.CSharp" Version="4.7.0" />
     <PackageReference Update="Microsoft.Data.SqlClient" Version="5.2.2" />
-    <PackageReference Update="Microsoft.Extensions.Azure" Version="1.11.0" />
+    <PackageReference Update="Microsoft.Extensions.Azure" Version="1.12.0" />
     <PackageReference Update="Microsoft.Extensions.Configuration.Abstractions" Version="8.0.0" />
     <PackageReference Update="Microsoft.Extensions.Configuration.Binder" Version="8.0.2" />
     <PackageReference Update="Microsoft.Extensions.Configuration.Json" Version="8.0.1" />

eng/common/pipelines/templates/steps/detect-api-changes.yml

@@ -5,24 +5,25 @@ parameters:
   Condition: true
 
 steps:
-  - pwsh: |
-      $apiChangeDetectRequestUrl = "https://apiview.dev/api/PullRequests/CreateAPIRevisionIfAPIHasChanges"
-      echo "##vso[task.setvariable variable=ApiChangeDetectRequestUrl]$apiChangeDetectRequestUrl"
-    displayName: "Set API change detect request URL"
-    condition: and(${{ parameters.Condition}}, eq(variables['ApiChangeDetectRequestUrl'], ''))
+  - ${{ if eq(variables['Build.Reason'],'PullRequest') }}:
+    - pwsh: |
+        $apiChangeDetectRequestUrl = "https://apiview.dev/api/PullRequests/CreateAPIRevisionIfAPIHasChanges"
+        echo "##vso[task.setvariable variable=ApiChangeDetectRequestUrl]$apiChangeDetectRequestUrl"
+      displayName: "Set API change detect request URL"
+      condition: and(${{ parameters.Condition}}, eq(variables['ApiChangeDetectRequestUrl'], ''))
 
-  - task: Powershell@2
-    inputs:
-      filePath: ${{ parameters.RepoRoot }}/eng/common/scripts/Detect-Api-Changes.ps1
-      arguments: >
-        -ArtifactPath ${{parameters.ArtifactPath}}
-        -CommitSha '$(System.PullRequest.SourceCommitId)'
-        -BuildId $(Build.BuildId)
-        -PullRequestNumber $(System.PullRequest.PullRequestNumber)
-        -RepoFullName $(Build.Repository.Name)
-        -APIViewUri $(ApiChangeDetectRequestUrl)
-        -ArtifactName ${{ parameters.ArtifactName }}
-        -DevopsProject $(System.TeamProject)
-      pwsh: true
-    displayName: Create APIView if API has changes
-    condition: and(${{ parameters.Condition }}, succeededOrFailed(), eq(variables['Build.Reason'],'PullRequest'))
+    - task: Powershell@2
+      inputs:
+        filePath: ${{ parameters.RepoRoot }}/eng/common/scripts/Detect-Api-Changes.ps1
+        arguments: >
+          -ArtifactPath ${{parameters.ArtifactPath}}
+          -CommitSha '$(System.PullRequest.SourceCommitId)'
+          -BuildId $(Build.BuildId)
+          -PullRequestNumber $(System.PullRequest.PullRequestNumber)
+          -RepoFullName $(Build.Repository.Name)
+          -APIViewUri $(ApiChangeDetectRequestUrl)
+          -ArtifactName ${{ parameters.ArtifactName }}
+          -DevopsProject $(System.TeamProject)
+        pwsh: true
+      displayName: Create APIView if API has changes
+      condition: and(${{ parameters.Condition }}, succeededOrFailed())

eng/common/spelling/package-lock.json

@@ -45,6 +45,7 @@
     "@azure-tools/typespec-azure-resource-manager": "0.56.2",
     "@azure-tools/typespec-azure-rulesets": "0.56.1",
     "@azure-tools/typespec-client-generator-core": "0.56.2",
+    "@azure-tools/typespec-liftr-base": "0.8.0",
     "@eslint/js": "^9.2.0",
     "@types/node": "~22.7.5",
     "@types/prettier": "^2.6.3",
@@ -72,6 +73,7 @@
     "@azure-tools/typespec-azure-resource-manager",
     "@azure-tools/typespec-azure-rulesets",
     "@azure-tools/typespec-client-generator-core",
+    "@azure-tools/typespec-liftr-base",
     "@typespec/compiler",
     "@typespec/http",
     "@typespec/openapi",

eng/packages/http-client-csharp-mgmt/package-lock.json

@@ -16,18 +16,35 @@ function Get-AllPackageInfoFromRepo($serviceDirectory)
   # Save-Package-Properties.ps1
   $shouldAddDevVersion = Get-Variable -Name 'addDevVersion' -ValueOnly -ErrorAction 'Ignore'
   $ServiceProj = Join-Path -Path $EngDir -ChildPath "service.proj"
-  Write-Host "dotnet msbuild /nologo /t:GetPackageInfo ""$ServiceProj"" /p:EnableCentralPackageVersions=False /p:ServiceDirectory=$serviceDirectory /p:AddDevVersion=$shouldAddDevVersion -tl:off"
+  $outputFilePath = Join-Path ([System.IO.Path]::GetTempPath()) "package-info-$([System.Guid]::NewGuid()).txt"
+  
+  Write-Host "dotnet msbuild /nologo /t:GetPackageInfo ""$ServiceProj"" /p:ServiceDirectory=$serviceDirectory /p:AddDevVersion=$shouldAddDevVersion /p:OutputProjectInfoListFilePath=""$outputFilePath"" -tl:off"
 
-  $msbuildOutput = dotnet msbuild `
+  dotnet msbuild `
     /nologo `
     /t:GetPackageInfo `
     "$ServiceProj" `
-    /p:EnableCentralPackageVersions=False `
     /p:ServiceDirectory=$serviceDirectory `
     /p:AddDevVersion=$shouldAddDevVersion `
-    -tl:off
+    /p:OutputProjectInfoListFilePath="$outputFilePath" `
+    -tl:off | Out-Host
+
+  # Check if msbuild succeeded
+  if ($LASTEXITCODE -ne 0) {
+    # Clean up temp file before failing
+    if (Test-Path $outputFilePath) {
+      $null = Remove-Item $outputFilePath -Force -ErrorAction SilentlyContinue
+    }
+    throw "MSBuild failed with exit code $LASTEXITCODE"
+  }
+
+  $packageInfoLines = @()
+  if (Test-Path $outputFilePath) {
+    $packageInfoLines = Get-Content $outputFilePath | Where-Object { $_ -and $_.Trim() }
+    $null = Remove-Item $outputFilePath -Force -ErrorAction SilentlyContinue
+  }
 
-  foreach ($projectOutput in $msbuildOutput)
+  foreach ($projectOutput in $packageInfoLines)
   {
     if (!$projectOutput) {
       Write-Verbose "Get-AllPackageInfoFromRepo::projectOutput was null or empty, skipping"