Skip to content

Conversation

@husnain067
Copy link
Collaborator

@husnain067 husnain067 commented Jun 13, 2025

Feature Pull Request

Branch Naming Convention

Current branch: feature/add-dev-container-json

Related Issue

Closes #194

Feature Description

Implement Visual Studio Code Dev Containers for PyLaunch Blueprint by creating a properly configured devcontainer.json file that provides a consistent development environment..

Implementation Details

Add Docker and VS Code Dev Container support to py-launch-blueprint, providing a consistent, isolated development environment.

Changes Made

  • Added .devcontainer/devcontainer.json configuration file.
  • Update the existing docker file to add relevant user guide.

Testing Performed

Locally test the environment is working inside the dev container created.

Testing Instructions

1: Docker Desktop installed and running.

2: Follow these steps to test it.

  • Open the project folder in VS Code.
  • When prompted, select “Reopen in Container.”
    Or run Cmd+Shift+P → Dev Containers: Reopen in Container.
  • Wait for the container to build.

3: Once inside the container
Run the following just commands in the terminal.

1: just format
2: just lint
3: just test

Need to verify that all the commands execute successfully without errors.

Documentation Updates

  • Update the docker.md file.

Breaking Changes

Checklist

  • Branch name follows convention (feature/description or feature/issue-number-description)
  • Testing added to pre-commit hook (pre-commit run --all-files passes)
  • Testing added to CI/CD pipeline in GitHub Actions
  • Documentation added/updated in Sphinx
  • Appropriate unit test coverage added (run pytest --cov to verify)
  • New commands added to CLI (if applicable)
  • Code follows project style guidelines (flake8 or equivalent passes)
  • All tests pass locally and in CI
  • Self-review of code performed
  • No debug print statements or commented-out code left in the codebase

Reviewer Notes

@husnain067 husnain067 added this to the v1 milestone Jun 13, 2025
@husnain067 husnain067 self-assigned this Jun 13, 2025
@github-actions
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@husnain067 husnain067 marked this pull request as ready for review June 13, 2025 23:05
@husnain067 husnain067 requested a review from smorin June 13, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add Dev Container Support for Cross-Platform Development

4 participants