-
-
Notifications
You must be signed in to change notification settings - Fork 13
Add and update docker-container setup files #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
husnain067
wants to merge
16
commits into
main
Choose a base branch
from
feature/add-dev-container-json
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Pull Request
Branch Naming Convention
Current branch:
feature/add-dev-container-jsonRelated Issue
Closes #194
Feature Description
Implement Visual Studio Code Dev Containers for PyLaunch Blueprint by creating a properly configured devcontainer.json file that provides a consistent development environment..
Implementation Details
Add Docker and VS Code Dev Container support to py-launch-blueprint, providing a consistent, isolated development environment.
Changes Made
Testing Performed
Locally test the environment is working inside the dev container created.
Testing Instructions
1: Docker Desktop installed and running.
2: Follow these steps to test it.
Or run
Cmd+Shift+P→ Dev Containers: Reopen in Container.3: Once inside the container
Run the following just commands in the terminal.
1:
just format2:
just lint3:
just testNeed to verify that all the commands execute successfully without errors.
Documentation Updates
docker.mdfile.Breaking Changes
Checklist
feature/descriptionorfeature/issue-number-description)pre-commit run --all-filespasses)pytest --covto verify)flake8or equivalent passes)Reviewer Notes