fix: schema generation with type keyword (#84) #87
+118
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I'm not sure why |
spumer
requested changes
Nov 28, 2025
| ), | ||
| ) | ||
| return api_dir | ||
| return request.param |
Collaborator
There was a problem hiding this comment.
Let's not change the fixture return type.
If you need access to some of the fixture params, you can follow one of the two ways:
- return a "smart" object and access its attributes
- create a fixture and access/control params through it
I would prefer the second method for this case:
@pytest.fixture(params=['no-collide', 'collide'])
def api_package_signature(request):
return request.param
@pytest.fixture()
def api_package(..., api_package_signature):
...| else: | ||
| assert web_request_ref != mobile_request_ref | ||
| assert web_request_ref.split('/')[-1] in schemas | ||
| assert mobile_request_ref.split('/')[-1] in schemas |
Collaborator
There was a problem hiding this comment.
Can we bring back hard-coded values to make the test clearer about which values are expected?
| from pydantic import BaseModel | ||
|
|
||
|
|
||
| def test_type_keyword_field(ep, app, app_client): |
Collaborator
There was a problem hiding this comment.
Suggested change
| def test_type_keyword_field(ep, app, app_client): | |
| def test_py312_type_keyword_field(ep, app, app_client): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
schema['title']if there is no 'title'request_responsefrom fastapi required in latest fastapi version. In previous fastapi versions there is an import from starlette (fastapi/fastapi@e329d78#diff-4d573079004a9f3d148baa4658e68e82b8a3d1a95d603fee8177daa92cf65c93)test_no_collide, because now fastapi generates schema with full nameapi.mobile._Response[probe]even if it's not necessary