Skip to content

Commit ff4c7c4

Browse files
committed
Added page._update_data() #129
1 parent e23b223 commit ff4c7c4

File tree

1 file changed

+12
-8
lines changed

1 file changed

+12
-8
lines changed

wptools/page.py

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ def __pull_image_info(self, title, imageinfo, normalized):
125125

126126
def _extend_data(self, datapoint, new_data):
127127
"""
128-
assigns or extends datapoint with new data
128+
extend or assign new data to datapoint
129129
"""
130130
if new_data:
131131
try:
@@ -336,16 +336,10 @@ def _set_query_data_fast_1(self, page):
336336

337337
self._extend_data('links', utils.get_links(page.get('links')))
338338

339-
modified = page.get('touched')
340-
if modified:
341-
if 'modified' in self.data:
342-
self.data['modified'].update({'page': modified})
343-
else:
344-
self.data['modified'] = {'page': modified}
339+
self._update_data('modified', 'page', page.get('touched'))
345340

346341
pageprops = page.get('pageprops')
347342
if pageprops:
348-
349343
wikibase = pageprops.get('wikibase_item')
350344
if wikibase:
351345
self.data['wikibase'] = wikibase
@@ -454,6 +448,16 @@ def _set_random_data(self):
454448
self.data.update({'pageid': pageid,
455449
'title': title})
456450

451+
def _update_data(self, datapoint, key, new_data):
452+
"""
453+
update or assign new data to datapoint
454+
"""
455+
if new_data:
456+
try:
457+
self.data[datapoint].update({key: new_data})
458+
except KeyError:
459+
self.data[datapoint] = {key: new_data}
460+
457461
def _update_imageinfo(self):
458462
"""
459463
calls get_imageinfo() if data image missing info

0 commit comments

Comments
 (0)