From d953407381cd8838e86042a8f6f67da8d3d2b388 Mon Sep 17 00:00:00 2001 From: Gonzalo Diaz Date: Thu, 25 Sep 2025 12:15:34 -0300 Subject: [PATCH 1/2] [BUGFIX] SonarQube: Do not call `Array#push()` multiple times. Multiple consecutive calls to methods that accept multiple arguments should be combined javascript:S7778 --- src/hackerrank/warmup/plusMinus.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/hackerrank/warmup/plusMinus.js b/src/hackerrank/warmup/plusMinus.js index 6a19869a..b264af04 100644 --- a/src/hackerrank/warmup/plusMinus.js +++ b/src/hackerrank/warmup/plusMinus.js @@ -17,11 +17,11 @@ function plusMinus(arr) { } } - const result = []; - - result.push((positives / arr.length).toFixed(6)); - result.push((negatives / arr.length).toFixed(6)); - result.push((zeros / arr.length).toFixed(6)); + const result = [ + (positives / arr.length).toFixed(6), + (negatives / arr.length).toFixed(6), + (zeros / arr.length).toFixed(6) + ]; return result.join(`\n`); } From 58517d5c7945022fb7cb59305573d84cbea9f43e Mon Sep 17 00:00:00 2001 From: Gonzalo Diaz Date: Thu, 25 Sep 2025 12:32:10 -0300 Subject: [PATCH 2/2] Prefer `Math.max()` to simplify ternary expressions. Ternary expressions should be replaced with "Math.min()" or "Math.max()" for simple comparisons javascript:S7766 --- .../dynamic_programming/max_array_sum.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/hackerrank/interview_preparation_kit/dynamic_programming/max_array_sum.js b/src/hackerrank/interview_preparation_kit/dynamic_programming/max_array_sum.js index b40ec95d..da1e680c 100644 --- a/src/hackerrank/interview_preparation_kit/dynamic_programming/max_array_sum.js +++ b/src/hackerrank/interview_preparation_kit/dynamic_programming/max_array_sum.js @@ -4,7 +4,11 @@ */ const bigIntMax = (...args) => - args.reduce((m, e) => (e > m ? e : m), BigInt(0)); + args.reduce((m, e) => { + const _e = BigInt(e); + const _m = BigInt(m); + return _e > _m ? _e : _m; + }, BigInt(0)); function maxSubsetSum(arr) { const arrCopy = arr.map(BigInt);