refactor: shortened some console-outputs and made config local for where it's needed

Author: sindrekjr

AdventOfCode/Infrastructure/Helpers/FormatHelper.cs

@@ -10,9 +10,7 @@ static class FormatHelper
 
         public static string FormatTitle(int day, string title) => $"Day {day}: {title}";
 
-        public static string FormatDebug(string debugInput) => string.IsNullOrEmpty(debugInput)
-            ? "!! Debug mode active, but no DebugInput defined"
-            : "!! Debug mode active, using DebugInput";
+        public static string FormatDebug(string debugInput) => "!! Debug mode active, using DebugInput";
 
         public static string FormatPart(int part, SolutionResult result)
             => $"  - Part{part} => " + (string.IsNullOrEmpty(result.Answer) ? "Unsolved" : $"{result.Answer} ({result.Time.TotalMilliseconds}ms)");

AdventOfCode/Infrastructure/Helpers/InputHelper.cs

@@ -1,11 +1,14 @@
 using System;
 using System.IO;
 using System.Net;
+using AdventOfCode.Infrastructure.Models;
 
 namespace AdventOfCode.Infrastructure.Helpers
 {
     static class InputHelper
     {
+        readonly static string cookie = Config.Get("config.json").Cookie;
+
         public static string LoadInput(int day, int year)
         {
             string INPUT_FILEPATH = GetDayPath(day, year) + "/input";
@@ -25,7 +28,7 @@ public static string LoadInput(int day, int year)
 
                     using (var client = new WebClient())
                     {
-                        client.Headers.Add(HttpRequestHeader.Cookie, Program.Config.Cookie);
+                        client.Headers.Add(HttpRequestHeader.Cookie, cookie);
                         input = client.DownloadString(INPUT_URL).Trim();
                         File.WriteAllText(INPUT_FILEPATH, input);
                     }
@@ -37,12 +40,12 @@ public static string LoadInput(int day, int year)
                     Console.ForegroundColor = ConsoleColor.DarkRed;
                     if (statusCode == HttpStatusCode.BadRequest)
                     {
-                        Console.WriteLine($"Day {day}: Error code 400 when attempting to retrieve puzzle input through the web client. Your session cookie is probably not recognized.");
+                        Console.WriteLine($"Day {day}: Received 400 when attempting to retrieve puzzle input. Your session cookie is probably not recognized.");
 
                     }
                     else if (statusCode == HttpStatusCode.NotFound)
                     {
-                        Console.WriteLine($"Day {day}: Error code 404 when attempting to retrieve puzzle input through the web client. The puzzle is probably not available yet.");
+                        Console.WriteLine($"Day {day}: Received 404 when attempting to retrieve puzzle input. The puzzle is probably not available yet.");
                     }
                     else
                     {

AdventOfCode/Infrastructure/Models/Config.cs

@@ -114,7 +114,7 @@ private IEnumerable<int> ParseString(string str)
                 {
                     return new int[] { day };
                 }
-                
+
                 return new int[0];
             });
         }

AdventOfCode/Infrastructure/SolutionCollector.cs

@@ -2,14 +2,18 @@
 using System.Collections;
 using System.Collections.Generic;
 using System.Linq;
+using AdventOfCode.Infrastructure.Models;
 using AdventOfCode.Solutions;
 
 namespace AdventOfCode.Infrastructure
 {
     class SolutionCollector : IEnumerable<ASolution>
     {
+        readonly static Config config = Config.Get("config.json");
+
         IEnumerable<ASolution> Solutions;
 
+        public SolutionCollector() => Solutions = LoadSolutions(config.Year, config.Days).ToArray();
         public SolutionCollector(int year, int[] days) => Solutions = LoadSolutions(year, days).ToArray();
 
         public ASolution GetSolution(int day)
@@ -26,7 +30,6 @@ public ASolution GetSolution(int day)
 
         public IEnumerator<ASolution> GetEnumerator() => Solutions.GetEnumerator();
 
-
         IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();
 
         IEnumerable<ASolution> LoadSolutions(int year, int[] days)

AdventOfCode/Program.cs

@@ -8,8 +8,7 @@ namespace AdventOfCode
 {
     class Program
     {
-        public static Config Config = Config.Get("config.json");
-        static SolutionCollector Solutions = new SolutionCollector(Config.Year, Config.Days);
+        static SolutionCollector Solutions = new SolutionCollector();
 
         static void Main(string[] args)
         {