Skip to content

Fix metadata load each call #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adriaandotcom wants to merge 2 commits into from
Closed

Fix metadata load each call #60

adriaandotcom wants to merge 2 commits into from

Conversation

@adriaandotcom
Copy link
Collaborator

@adriaandotcom adriaandotcom commented May 27, 2025

Summary

  • re-fetch sa_metadata inside appendMetadata
  • remove trailing commas to maintain ES5 compatibility
  • add unit test for appendMetadata

Testing

  • npx prettier src/default.js test/test-append-metadata.js --trailing-comma es5 --check
  • npx mocha test/test-append-metadata.js

@adriaandotcom adriaandotcom deleted the w2d188-codex/load-sa_metadata-on-appendmetadata()-and-add-test branch May 27, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adriaandotcom