Add proper handle for unable for access error

Author: sigseg5

src/Utilities/git_utilities.py

@@ -23,10 +23,14 @@ def git_action(*args):
         if (pull_proc_out.decode('utf-8')).count("Already up-to-date.") == 1 or \
                 (pull_proc_out.decode('utf-8')).count("Already up to date.") == 1:
             return True
+        elif (pull_proc_out.decode('utf-8')).count("fatal: unable for access") != 0:
+            sys_exit(1)
 
     elif len(args) == 3 and args[0] == "clone":
         print("git clone {repo} {path}".format(repo=args[1], path=args[2]))
-        _ = call(["git", "clone", args[1], args[2]])
+        clone_proc_out = check_output(["git", "clone", args[1], args[2]])
+        if (clone_proc_out.decode('utf-8')).count("fatal: unable for access") != 0:
+            sys_exit(1)
 
     else:
         print("Unexpected args error.")

updater.py

@@ -15,7 +15,7 @@
 from src.Utilities.installer import make_action
 from src.Utilities.installer import check_make_installation_status
 
-UPDATER_VER = "1.1.4"
+UPDATER_VER = "1.2.0"
 GIT_DOWNLOAD_PAGE = "http://git-scm.com/"
 VIM_DOWNLOAD_PAGE = "https://www.vim.org/download.php#pc"
 VIM_REPO = "https://github.com/vim/vim.git"
@@ -29,8 +29,13 @@ def clean_install():
     Function to perform clean installation of vim: `git clone` and `make install`
     :return:
     """
-    print("Starting git clone, it may not be quite fast")
-    git_action("clone", VIM_REPO, USER_FOLDER + UPDATER_DIR)
+    print("Starting git clone, it may not be quite fast.")
+    try:
+        git_action("clone", VIM_REPO, USER_FOLDER + UPDATER_DIR)
+    except Exception:
+        print("Fatal error: unable for access.\nCheck internet connection.")
+        sys_exit(1)
+
     print("Current vim version in src:\n" + check_current_vim_version_in_src(USER_FOLDER + UPDATER_DIR))
     make_action("make", USER_FOLDER + UPDATER_DIR)
     make_action("install", USER_FOLDER + UPDATER_DIR)
@@ -104,27 +109,30 @@ def main():
                git_status=git_version_output))
 
     if path.isdir(USER_FOLDER) and path.exists(USER_FOLDER + UPDATER_DIR):
-        print("Work folder and updater dir here, check vim src folder")
+        print("Work folder and updater dir here, checking vim src folder…")
         if path.exists(USER_FOLDER + UPDATER_DIR):
-            print("VIM folder here")
             if not path.exists(USER_FOLDER + UPDATER_DIR + "/.git"):
-                print("Can't find .git folder")
-                print("Removing work folder")
+                print("Can't find .git folder.")
+                print("Removing work folder…")
                 rmtree(USER_FOLDER + UPDATER_DIR)
-                print("Work folder remover successfully, please run updater again")
+                print("Work folder remover successfully, please run updater again.")
                 sys_exit(0)
 
             print("Pulling from github...")
-            is_updated = git_action("pull", USER_FOLDER + UPDATER_DIR)
+            try:
+                is_updated = git_action("pull", USER_FOLDER + UPDATER_DIR)
+            except Exception:
+                print("Fatal error: unable for access.\nCheck internet connection.")
+                sys_exit(1)
 
             if is_updated:
-                print("VIM already up to date\n")
+                print("VIM already up to date.\n")
                 print(check_current_vim_version_in_system())
                 sys_exit(0)
             print(check_current_vim_version_in_src(USER_FOLDER + UPDATER_DIR))
             make_action("make", USER_FOLDER + UPDATER_DIR)
             make_action("install", USER_FOLDER + UPDATER_DIR)
-            print("vim updated to {}".format(check_current_vim_version_in_system()))
+            print("vim updated to {}.".format(check_current_vim_version_in_system()))
 
         else:
             clean_install()
@@ -144,7 +152,7 @@ def main():
         clean_install()
 
     else:
-        print("Error with user folder: {user_folder}".format(user_folder=USER_FOLDER))
+        print("Error with user folder: {user_folder}.".format(user_folder=USER_FOLDER))
         sys_exit(1)