Simplify isNumeric

Author: janedbal

src/Rule/ForbidArithmeticOperationOnNonNumberRule.php

@@ -137,15 +137,13 @@ private function processBinary(
 
     private function isNumeric(Type $type): bool
     {
-        $int = new IntegerType();
-        $float = new FloatType();
-        $bcNumber = new ObjectType('BcMath\Number');
-        $intOrFloatOrBcNumber = new UnionType([$int, $float, $bcNumber]);
+        $numericUnion = new UnionType([
+            new IntegerType(),
+            new FloatType(),
+            new ObjectType('BcMath\Number'),
+        ]);
 
-        return $int->isSuperTypeOf($type)->yes()
-            || $float->isSuperTypeOf($type)->yes()
-            || $bcNumber->isSuperTypeOf($type)->yes()
-            || $intOrFloatOrBcNumber->isSuperTypeOf($type)->yes()
+        return $numericUnion->isSuperTypeOf($type)->yes()
             || ($this->allowNumericString && $type->isNumericString()->yes());
     }
 

tests/Rule/data/ForbidArithmeticOperationOnNonNumberRule/code.php

@@ -130,6 +130,8 @@ public function testUnions(
         -$intFloat;
         -$intFloatString; // error: Using - over non-number (float|int|string)
         -$intArray; // error: Using - over non-number (array|int)
+
+        $intString - $intArray; // error: Using - over non-number (int|string - array|int)
     }
 
     /**