Changing debug refs not to invalidate result cache (#169)

Author: janedbal

README.md

@@ -390,6 +390,9 @@ App\User\Entity\Address::__construct
 
 If you set up `editorUrl` [parameter](https://phpstan.org/user-guide/output-format#opening-file-in-an-editor), you can click on the usages to open it in your IDE.
 
+> [!TIP]
+> You can change the list of debug references without affecting result cache, so rerun is instant!
+
 ## Future scope:
 - Dead class property detection
 - Dead class detection

composer.json

@@ -13,7 +13,7 @@
     ],
     "require": {
         "php": "^7.4 || ^8.0",
-        "phpstan/phpstan": "^2.1.7"
+        "phpstan/phpstan": "^2.1.9"
     },
     "require-dev": {
         "composer-runtime-api": "^2.0",

composer.lock

@@ -121,6 +121,9 @@ services:
 
 
 parameters:
+    parametersNotInvalidatingCache:
+        - parameters.shipmonkDeadCode.debug.usagesOf
+        - parameters.shipmonkDeadCode.reportTransitivelyDeadMethodAsSeparateError
     shipmonkDeadCode:
         trackMixedAccess: null
         reportTransitivelyDeadMethodAsSeparateError: false

rules.neon

@@ -107,7 +107,7 @@ private function extractConstantsUsedByReflection(
         }
 
         if (($methodName === 'getConstant' || $methodName === 'getReflectionConstant') && count($args) === 1) {
-            $firstArg = $args[array_key_first($args)]; // @phpstan-ignore offsetAccess.notFound
+            $firstArg = $args[array_key_first($args)];
 
             foreach ($scope->getType($firstArg->value)->getConstantStrings() as $constantString) {
                 $usedConstants[] = $this->createConstantUsage($node, $scope, $genericReflection->getName(), $constantString->getValue());
@@ -138,7 +138,7 @@ private function extractMethodsUsedByReflection(
         }
 
         if ($methodName === 'getMethod' && count($args) === 1) {
-            $firstArg = $args[array_key_first($args)]; // @phpstan-ignore offsetAccess.notFound
+            $firstArg = $args[array_key_first($args)];
 
             foreach ($scope->getType($firstArg->value)->getConstantStrings() as $constantString) {
                 $usedMethods[] = $this->createMethodUsage($node, $scope, $genericReflection->getName(), $constantString->getValue());