Changing debug refs not to invalidate result cache

janedbal · janedbal · commit 332aa31beaf2 · 2025-03-14T15:55:42.000+01:00
diff --git a/composer.json b/composer.json
@@ -13,7 +13,7 @@
     ],
     "require": {
         "php": "^7.4 || ^8.0",
-        "phpstan/phpstan": "^2.1.7"
+        "phpstan/phpstan": "2.1.x-dev"
     },
     "require-dev": {
         "composer-runtime-api": "^2.0",
diff --git a/composer.lock b/composer.lock
diff --git a/rules.neon b/rules.neon
@@ -116,6 +116,8 @@ services:
 
 
 parameters:
+    parametersNotInvalidatingCache:
+        - parameters.shipmonkDeadCode.debug.usagesOf
     shipmonkDeadCode:
         trackMixedAccess: true
         reportTransitivelyDeadMethodAsSeparateError: false
diff --git a/src/Provider/ReflectionUsageProvider.php b/src/Provider/ReflectionUsageProvider.php
@@ -107,7 +107,7 @@ private function extractConstantsUsedByReflection(
         }
 
         if (($methodName === 'getConstant' || $methodName === 'getReflectionConstant') && count($args) === 1) {
-            $firstArg = $args[array_key_first($args)]; // @phpstan-ignore offsetAccess.notFound
+            $firstArg = $args[array_key_first($args)];
 
             foreach ($scope->getType($firstArg->value)->getConstantStrings() as $constantString) {
                 $usedConstants[] = $this->createConstantUsage($node, $scope, $genericReflection->getName(), $constantString->getValue());
@@ -138,7 +138,7 @@ private function extractMethodsUsedByReflection(
         }
 
         if ($methodName === 'getMethod' && count($args) === 1) {
-            $firstArg = $args[array_key_first($args)]; // @phpstan-ignore offsetAccess.notFound
+            $firstArg = $args[array_key_first($args)];
 
             foreach ($scope->getType($firstArg->value)->getConstantStrings() as $constantString) {
                 $usedMethods[] = $this->createMethodUsage($node, $scope, $genericReflection->getName(), $constantString->getValue());

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ private function extractConstantsUsedByReflection(`
`107`	`107`	`}`
`108`	`108`
`109`	`109`	`if (($methodName === 'getConstant' \|\| $methodName === 'getReflectionConstant') && count($args) === 1) {`
`110`		`- $firstArg = $args[array_key_first($args)]; // @phpstan-ignore offsetAccess.notFound`
	`110`	`+ $firstArg = $args[array_key_first($args)];`
`111`	`111`
`112`	`112`	`foreach ($scope->getType($firstArg->value)->getConstantStrings() as $constantString) {`
`113`	`113`	`$usedConstants[] = $this->createConstantUsage($node, $scope, $genericReflection->getName(), $constantString->getValue());`
`@@ -138,7 +138,7 @@ private function extractMethodsUsedByReflection(`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`if ($methodName === 'getMethod' && count($args) === 1) {`
`141`		`- $firstArg = $args[array_key_first($args)]; // @phpstan-ignore offsetAccess.notFound`
	`141`	`+ $firstArg = $args[array_key_first($args)];`
`142`	`142`
`143`	`143`	`foreach ($scope->getType($firstArg->value)->getConstantStrings() as $constantString) {`
`144`	`144`	`$usedMethods[] = $this->createMethodUsage($node, $scope, $genericReflection->getName(), $constantString->getValue());`