Remove dead code from run_rake_task_directly method

[justin808]

Summary

Remove 3 lines of dead code from the run_rake_task_directly method in lib/react_on_rails/dev/pack_generator.rb.

Details

The method has some unreachable or unused code that can be safely removed without affecting functionality.

Related Branch

This fix was identified in the justin808/shakapacker-9.3.0 branch (commit b716f08).

Impact

• Cleanup only, no functional change
• Makes the code cleaner and easier to maintain

Files Changed

• lib/react_on_rails/dev/pack_generator.rb (3 lines removed)

Labels

• Easy
• Low priority

[coderabbitai]

A summary of the changes CodeRabbit can apply:

• Apply the dead-code-removal fix to master by updating lib/react_on_rails/dev/pack_generator.rb: refactor generate to delegate to a new run_pack_generation helper, add private helpers (run_pack_generation, rails_available?, run_rake_task_directly, run_via_bundle_exec), and remove the unreachable require ... unless defined?(Rails) lines while preserving existing behavior.

• Update lib/react_on_rails/dev/pack_generator.rb to replace direct system calls with a new run_pack_generation(silent:) workflow that detects if Rails is available to run the rake task directly (via run_rake_task_directly with optional stdout/stderr suppression) or falls back to bundle exec (run_via_bundle_exec), adding private helper methods (run_pack_generation, rails_available?, run_rake_task_directly, run_via_bundle_exec) and error handling.

• ✅ Create PR with these edits
• 📋 Get copyable edits