Missed yarn->pnpm replacements

alexeyr · alexeyr · commit 4cf7fab9bab3 · 2025-12-08T15:23:54.000Z
diff --git a/.claude/agents/pr-testing-agent.md b/.claude/agents/pr-testing-agent.md
@@ -76,10 +76,10 @@ bundle exec rake rbs:validate          # Type signatures valid
 
 **Automated (CI covers):**
 
-- ✅ Jest unit tests (`yarn run test`)
-- ✅ TypeScript compilation (`yarn run type-check`)
-- ✅ ESLint (`yarn run lint`)
-- ✅ Prettier formatting (`yarn start format.listDifferent`)
+- ✅ Jest unit tests (`pnpm run test`)
+- ✅ TypeScript compilation (`pnpm run type-check`)
+- ✅ ESLint (`pnpm run lint`)
+- ✅ Prettier formatting (`pnpm start format.listDifferent`)
 
 **Manual verification required:**
 
diff --git a/.claude/agents/pr-testing-guide.md b/.claude/agents/pr-testing-guide.md
@@ -426,8 +426,8 @@ gh pr create  # Include testing summary from agent
 
 - [ ] RuboCop passes (`bundle exec rubocop`)
 - [ ] RSpec unit tests pass (`rake run_rspec:gem`)
-- [ ] Jest tests pass (`yarn run test`)
-- [ ] TypeScript compiles (`yarn run type-check`)
+- [ ] Jest tests pass (`pnpm run test`)
+- [ ] TypeScript compiles (`pnpm run type-check`)
 - [ ] RBS validation passes (`rake rbs:validate`)
 - [ ] Prettier formatting applied (`rake autofix`)
 
@@ -444,19 +444,19 @@ gh pr create  # Include testing summary from agent
 
 #### If JS/TS files changed:
 
-- [ ] Run tests locally: `yarn run test`
-- [ ] Build succeeds: `yarn run build`
+- [ ] Run tests locally: `pnpm run test`
+- [ ] Build succeeds: `pnpm run build`
 - [ ] Test in browser: `cd spec/dummy && bin/dev`
 - [ ] Check browser console for errors
 - [ ] If SSR code changed: Verify SSR output in page source
 
 #### If build configs changed:
 
-- [ ] **MANDATORY**: Clean install test: `rm -rf node_modules && yarn install --frozen-lockfile`
-- [ ] **MANDATORY**: Build test: `yarn run build && ls -la packages/react-on-rails/lib/`
-- [ ] **MANDATORY**: Prepack test: `yarn nps build.prepack`
-- [ ] **MANDATORY**: yalc publish test: `yarn run yalc:publish`
-- [ ] Workspace linking: `yarn workspaces info`
+- [ ] **MANDATORY**: Clean install test: `rm -rf node_modules && pnpm install --frozen-lockfile`
+- [ ] **MANDATORY**: Build test: `pnpm run build && ls -la packages/react-on-rails/lib/`
+- [ ] **MANDATORY**: Prepack test: `pnpm nps build.prepack`
+- [ ] **MANDATORY**: yalc publish test: `pnpm run yalc:publish`
+- [ ] Workspace linking: `pnpm workspaces info`
 - [ ] Full test suite: `bundle exec rake`
 
 #### If webpack configs changed:
@@ -479,7 +479,7 @@ gh pr create  # Include testing summary from agent
 
 #### If user-facing behavior changed (React components, SSR, view helpers):
 
-- [ ] Run Playwright E2E tests: `cd spec/dummy && yarn test:e2e`
+- [ ] Run Playwright E2E tests: `cd spec/dummy && pnpm test:e2e`
 - [ ] Verify components render in browser
 - [ ] Check server-side rendering in view source
 - [ ] No JavaScript console errors
diff --git a/.claude/docs/analysis/CI_FAILURES_2024-11-21.md b/.claude/docs/analysis/CI_FAILURES_2024-11-21.md
@@ -479,7 +479,7 @@ When changing directory structure:
 
 1. Update ALL path references in configuration files
 2. Search codebase: `grep -r "old/path"`
-3. Test scripts: `yarn run prepack`, `yarn run yalc.publish`
+3. Test scripts: `yarn run prepack`, `yarn run yalc:publish`
 4. Run full test suite before committing
 
 ---
diff --git a/.claude/docs/analysis/CLAUDE_MD_UPDATES.md b/.claude/docs/analysis/CLAUDE_MD_UPDATES.md
@@ -67,7 +67,7 @@ Add this new section to CLAUDE.md (both root and .conductor/london-v1):
 2. **Test yalc publish (CRITICAL):**
 
    ```bash
-   yarn run yalc.publish
+   yarn run yalc:publish
    # Should publish successfully
    ```
 
@@ -103,7 +103,7 @@ In Sep 2024, we moved `node_package/` → `packages/react-on-rails/`. The path i
 package-scripts.yml was updated to `packages/react-on-rails/lib/ReactOnRails.full.js`.
 Later, the structure was partially reverted to `lib/` at root, but package-scripts.yml
 wasn't updated. This broke yalc publish silently for 7 weeks. Manual testing of
-`yarn run yalc.publish` would have caught this immediately.
+`yarn run yalc:publish` would have caught this immediately.
 
 ````
 
@@ -157,7 +157,7 @@ Some failures don't show up in standard CI:
 
 **Always manually test critical workflows:**
 
-- If you changed package structure → test `yarn run yalc.publish`
+- If you changed package structure → test `yarn run yalc:publish`
 - If you changed build configs → test `yarn build && ls -la lib/`
 - If you changed generators → test `rake run_rspec:example_basic`
 
@@ -199,7 +199,7 @@ Add this new section to CLAUDE.md (both versions):
    ```bash
    # If it's a build artifact path in package-scripts.yml:
    yarn run prepack
-   yarn run yalc.publish
+   yarn run yalc:publish
 
    # If it's a webpack output path:
    yarn build && ls -la <output-path>
@@ -238,7 +238,7 @@ find . -name "package.json" -type f
 
 # 3. Test package scripts
 yarn run prepack
-yarn run yalc.publish
+yarn run yalc:publish
 
 # 4. Test clean install
 rm -rf node_modules && yarn install
@@ -259,7 +259,7 @@ rake
 **How to prevent:**
 
 1. After changing directory structure, search for ALL references to old paths
-2. Always run `yarn run yalc.publish` manually to verify it works
+2. Always run `yarn run yalc:publish` manually to verify it works
 3. Check that paths in package-scripts.yml match actual file locations
 4. Use `ls -la <path>` to verify paths exist before committing
 
@@ -288,7 +288,7 @@ Update the existing "Merge Conflict Resolution Workflow" section with this addit
 7. **TEST CRITICAL SCRIPTS if build configs changed:**
    ```bash
    yarn run prepack          # Test prepack script
-   yarn run yalc.publish     # Test yalc publish if package structure changed
+   yarn run yalc:publish     # Test yalc publish if package structure changed
    rake run_rspec:gem        # Run relevant test suites
 ````
 
diff --git a/.claude/docs/analysis/INDEX.md b/.claude/docs/analysis/INDEX.md
@@ -161,7 +161,7 @@ Outside the analysis directory:
 **Critical Risk**: Path validation for yalc publish
 
 - Past incident: 7-week silent failure (Sept 2024)
-- Prevention: Always test `yarn run yalc.publish` manually
+- Prevention: Always test `yarn run yalc:publish` manually
 
 **Packages in Migration**:
 
diff --git a/.claude/docs/analysis/MIGRATION_QUICK_REFERENCE.md b/.claude/docs/analysis/MIGRATION_QUICK_REFERENCE.md
@@ -114,7 +114,7 @@ react_on_rails_pro/packages/    →   packages/react-on-rails-pro/lib/
 ```
 Path Migration Testing
 - [ ] Verify all paths in package-scripts.yml
-- [ ] Test yarn run yalc.publish manually
+- [ ] Test yarn run yalc:publish manually
 - [ ] Check package.json main/exports/files fields
 - [ ] Search for hardcoded node_package/ references
 
@@ -158,7 +158,7 @@ Documentation Testing
 ```bash
 yarn run prepack  # Test prepack script
 ls -la lib/ReactOnRails.full.js  # Verify path exists
-yarn run yalc.publish  # Manual test
+yarn run yalc:publish  # Manual test
 ```
 
 ### Issue: Workspace packages not building
diff --git a/.claude/docs/analysis/MONOREPO_MIGRATION_ANALYSIS.md b/.claude/docs/analysis/MONOREPO_MIGRATION_ANALYSIS.md
@@ -491,7 +491,7 @@ GitHub Actions
    - [ ] Update all `package-scripts.yml` paths
    - [ ] Update all CI workflow paths
    - [ ] Search codebase for hardcoded `node_package/` references
-   - [ ] Run `yarn run yalc.publish` manually (critical!)
+   - [ ] Run `yarn run yalc:publish` manually (critical!)
 
 3. **Documentation Alignment**
    - [ ] Update CONTRIBUTING.md section on npm development
diff --git a/.claude/docs/analysis/claude-md-improvements.md b/.claude/docs/analysis/claude-md-improvements.md
@@ -47,7 +47,7 @@ Based on the CI breakage analysis, here are specific additions to prevent simila
    yarn run prepack
 
    # Test yalc publish (critical for local development)
-   yarn run yalc.publish
+   yarn run yalc:publish
 
    # Verify build artifacts exist at expected paths
    ls -la lib/ReactOnRails.full.js
@@ -110,7 +110,7 @@ Based on the CI breakage analysis, here are specific additions to prevent simila
 6. **Continue rebase/merge**: `git rebase --continue` or `git commit`
 7. **TEST CRITICAL SCRIPTS**: If package-scripts.yml or build configs changed:
    - Run `yarn run prepack` to verify build scripts work
-   - Run `yarn run yalc.publish` if package structure changed
+   - Run `yarn run yalc:publish` if package structure changed
    - Run relevant test suites
 
 **❌ NEVER manually format during conflict resolution** - this causes formatting wars.
diff --git a/.claude/docs/analysis/github-issue-1765-update.md b/.claude/docs/analysis/github-issue-1765-update.md
@@ -73,7 +73,7 @@ The monorepo merger has been successfully completed with full git history preser
 #### Validation Requirements
 
 - [ ] `yarn run prepack` succeeds
-- [ ] `yarn run yalc.publish` works for each package
+- [ ] `yarn run yalc:publish` works for each package
 - [ ] `yarn build` outputs to correct directories
 - [ ] `rake node_package` generates correct structure
 - [ ] Full test suite passes: `rake`
@@ -215,7 +215,7 @@ The monorepo merger has been successfully completed with full git history preser
 2. **Test current YALC publishing** (10 min)
 
    ```bash
-   yarn run yalc.publish
+   yarn run yalc:publish
    # Verify success and check published location
    ```
 
diff --git a/.claude/docs/managing-file-paths.md b/.claude/docs/managing-file-paths.md
@@ -15,7 +15,7 @@
    ```bash
    # If it's a build artifact path in package-scripts.yml:
    yarn run prepack
-   yarn run yalc.publish
+   yarn run yalc:publish
 
    # If it's a webpack output path:
    yarn build && ls -la <output-path>
@@ -54,7 +54,7 @@ find . -name "package.json" -type f
 
 # 3. Test package scripts
 yarn run prepack
-yarn run yalc.publish
+yarn run yalc:publish
 
 # 4. Test clean install
 rm -rf node_modules && yarn install
@@ -75,6 +75,6 @@ rake
 **How to prevent:**
 
 1. After changing directory structure, search for ALL references to old paths
-2. Always run `yarn run yalc.publish` manually to verify it works
+2. Always run `pnpm run yalc:publish` manually to verify it works
 3. Check that paths in package-scripts.yml match actual file locations
 4. Use `ls -la <path>` to verify paths exist before committing
diff --git a/.claude/docs/master-health-monitoring.md b/.claude/docs/master-health-monitoring.md
@@ -69,8 +69,8 @@ Some failures don't show up in standard CI:
 
 **Always manually test critical workflows:**
 
-- If you changed package structure → test `yarn run yalc.publish`
-- If you changed build configs → test `yarn build && ls -la lib/`
+- If you changed package structure → test `pnpm run yalc:publish`
+- If you changed build configs → test `pnpm build && ls -la lib/`
 - If you changed generators → test `rake run_rspec:example_basic`
 
 ## Understanding Workflow Reruns
diff --git a/CLAUDE.md b/CLAUDE.md
@@ -387,7 +387,7 @@ For each suspicious entry:
 7. **TEST CRITICAL SCRIPTS if build configs changed:**
    ```bash
    pnpm run prepack          # Test prepack script
-   pnpm run yalc.publish     # Test yalc publish if package structure changed
+   pnpm run yalc:publish     # Test yalc publish if package structure changed
    rake run_rspec:gem        # Run relevant test suites
    ```
 
diff --git a/CODING_AGENTS.md b/CODING_AGENTS.md
@@ -30,7 +30,7 @@ cd spec/dummy && foreman start       # Start dummy app with webpack
 - [ ] No trailing whitespace
 - [ ] Line length ≤120 characters
 - [ ] Security violations properly scoped with disable comments
-- [ ] No `package-lock.json` or other non-Yarn lock files (except `Gemfile.lock`)
+- [ ] No `package-lock.json`, `yarn.lock` or other non-PNPM lock files (except `Gemfile.lock`)
 
 ## Development Patterns for AI Contributors
 
@@ -249,7 +249,7 @@ Use `gh pr create` with:
 
 - Don't assume packages are installed globally
 - Use `bundle exec` for Ruby commands
-- Verify setup with `bundle && yarn` when needed
+- Verify setup with `bundle && pnpm` when needed
 
 ### 4. RuboCop Configuration
 
diff --git a/SWITCHING_CI_CONFIGS.md b/SWITCHING_CI_CONFIGS.md
@@ -127,7 +127,7 @@ This will:
    - Shakapacker 9.3.0 → 8.2.0
    - React 19.0.0 → 18.0.0
    - Remove ESLint and other packages incompatible with Node 20
-3. Clean `node_modules` and `yarn.lock`
+3. Clean `node_modules` and `pnpm-lock.yaml`
 4. Reinstall dependencies without `--frozen-lockfile`
 5. Clean and reinstall spec/dummy dependencies
 
@@ -159,7 +159,7 @@ This will:
 
 1. Create `.tool-versions` with Ruby 3.4.3 and Node 22.12.0
 2. Restore files from git (reverting changes made by `script/convert`)
-3. Clean `node_modules` and `yarn.lock`
+3. Clean `node_modules` and `pnpm-lock.yaml`
 4. Reinstall dependencies with `--frozen-lockfile`
 5. Clean and reinstall spec/dummy dependencies
 
@@ -190,8 +190,8 @@ When switching to **minimum**, these files are modified:
 - `package.json` - React versions, dev dependencies removed
 - `spec/dummy/package.json` - React and Shakapacker versions
 - `packages/react-on-rails-pro/package.json` - Test scripts modified
-- `node_modules/`, `yarn.lock` - Cleaned and regenerated
-- `spec/dummy/node_modules/`, `spec/dummy/yarn.lock` - Cleaned and regenerated
+- `node_modules/`, `pnpm-lock.yaml` - Cleaned and regenerated
+- `spec/dummy/node_modules/`, `spec/dummy/pnpm-lock.yaml` - Cleaned and regenerated
 
 When switching to **latest**, these files are restored from git.
 
@@ -292,15 +292,15 @@ ruby --version
 node --version
 ```
 
-### Yarn install fails
+### PNPM install fails
 
 If you get package resolution errors:
 
 ```bash
 # Clean everything and try again
-rm -rf node_modules yarn.lock spec/dummy/node_modules spec/dummy/yarn.lock
-yarn install
-cd spec/dummy && yarn install
+rm -rf node_modules pnpm-lock.yaml react_on_rails/spec/dummy/node_modules react_on_rails/spec/dummy/pnpm-lock.yaml
+pnpm install -r
+cd react_on_rails/spec/dummy && pnpm install
 ```
 
 ### Git complains about modified files
diff --git a/WARP.md b/WARP.md
@@ -201,7 +201,7 @@ This project maintains two distinct but integrated packages:
 ### Making Code Changes
 
 1. Make changes to Ruby or TypeScript code
-2. For NPM changes: `yarn run build` or `yarn run build-watch`
+2. For NPM changes: `pnpm run build` or `pnpm run build-watch`
 3. For Yalc testing: `yalc push`
 4. Run relevant tests
 5. **Run `rake autofix`** to fix all linting
@@ -212,7 +212,7 @@ This project maintains two distinct but integrated packages:
 1. Create failing test that reproduces issue
 2. Implement minimal fix
 3. Ensure all tests pass
-4. Run linting: `bundle exec rubocop` and `yarn run lint`
+4. Run linting: `bundle exec rubocop` and `pnpm run lint`
 5. Update documentation if needed
 
 ### Adding Features
@@ -305,7 +305,7 @@ subject(:method_result) { instance.method_name(arg) }
 
 ### Package Manager
 
-- **ONLY use Yarn Classic (1.x)** - never use npm
+- **ONLY use PNPM** - never use npm
 - Package manager enforced via `packageManager` field in package.json
 
 ### Dependencies
@@ -342,7 +342,7 @@ subject(:method_result) { instance.method_name(arg) }
 ### Test Failures
 
 - Run tests from correct directory (project root vs spec/dummy)
-- Check that `bundle install` and `yarn install` are current
+- Check that `bundle install` and `pnpm install -r` are current
 - Verify git hooks are installed: `bundle exec lefthook install`
 
 ### Linting Failures
diff --git a/analysis/monorepo/MONOREPO_MIGRATION_CHECKLIST.md b/analysis/monorepo/MONOREPO_MIGRATION_CHECKLIST.md
@@ -64,7 +64,7 @@ The monorepo migration is in **Phase 2 (Git Merger) - COMPLETE**. We've successf
 ### Build System Validation
 
 - [ ] Test `yarn run prepack` succeeds
-- [ ] Test `yarn run yalc.publish` for each package
+- [ ] Test `yarn run yalc:publish` for each package
 - [ ] Verify `yarn build` outputs to correct directories
 - [ ] Check `ls -la packages/*/lib/*.js` shows all artifacts
 - [ ] Test clean install: `rm -rf node_modules && yarn install`
diff --git a/conductor-setup.sh b/conductor-setup.sh
@@ -16,7 +16,7 @@ echo "🚀 Setting up React on Rails workspace..."
 # Check required tools
 echo "📋 Checking required tools..."
 command -v bundle >/dev/null 2>&1 || { echo "❌ Error: bundler is not installed. Please install Ruby and bundler first."; exit 1; }
-command -v yarn >/dev/null 2>&1 || { echo "❌ Error: yarn is not installed. Please install yarn first."; exit 1; }
+command -v pnpm >/dev/null 2>&1 || { echo "❌ Error: pnpm is not installed. Please install pnpm first."; exit 1; }
 command -v node >/dev/null 2>&1 || { echo "❌ Error: Node.js is not installed. Please install Node.js first."; exit 1; }
 
 # Check Ruby version
@@ -56,11 +56,11 @@ bundle install
 
 # Install JavaScript dependencies
 echo "📦 Installing JavaScript dependencies..."
-yarn install
+pnpm install -r
 
 # Build the TypeScript package
 echo "🔨 Building TypeScript package..."
-yarn run build
+pnpm run build
 
 # Generate the node package
 echo "📦 Generating node package..."
@@ -73,7 +73,7 @@ bundle exec lefthook install || echo "⚠️ Could not install lefthook hooks"
 # Run initial linting to ensure everything is set up correctly
 echo "✅ Running initial linting checks..."
 bundle exec rubocop --version
-yarn run type-check || echo "⚠️ Type checking had issues"
+pnpm run type-check || echo "⚠️ Type checking had issues"
 
 echo "✨ Workspace setup complete!"
 echo ""
diff --git a/packages/react-on-rails-pro-node-renderer/script/preinstall.js b/packages/react-on-rails-pro-node-renderer/script/preinstall.js
diff --git a/react_on_rails/spec/dummy/Procfile.dev b/react_on_rails/spec/dummy/Procfile.dev
diff --git a/react_on_rails/spec/dummy/README.md b/react_on_rails/spec/dummy/README.md
diff --git a/react_on_rails_pro/spec/dummy/Procfile.static b/react_on_rails_pro/spec/dummy/Procfile.static
diff --git a/react_on_rails_pro/spec/dummy/README.md b/react_on_rails_pro/spec/dummy/README.md
diff --git a/react_on_rails_pro/spec/dummy/config/initializers/react_on_rails.rb b/react_on_rails_pro/spec/dummy/config/initializers/react_on_rails.rb
diff --git a/react_on_rails_pro/spec/dummy/lib/tasks/assets.rake b/react_on_rails_pro/spec/dummy/lib/tasks/assets.rake
