Skip to content

Commit 7441376

Browse files
fix: 🐛 [JIRA:0] Modified icon alignment of the banner message (SAP#1020)
Modified the icon alignment to the first line of the banner message and AI notice message based on UX review feedback Co-authored-by: I824136 <xiaoqing.he@sap.com>
1 parent 74e55cb commit 7441376

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

Apps/Examples/Examples/FioriSwiftUICore/BannerMessage/BannerMessageModifierExample.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ struct BannerMessageModifierExample: View {
2828
Text("\(text) with [link](https://www.sap.com)")
2929
} else if self.withAttachedAction {
3030
HStack {
31-
Spacer()
3231
Text("\(text)")
3332
Button(action: {
3433
print("Custom button tapped in title")

Sources/FioriSwiftUICore/_FioriStyles/AINoticeStyle.fiori.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import SwiftUI
66
public struct AINoticeBaseStyle: AINoticeStyle {
77
@Environment(\.isEnabled) var isEnabled
88
public func makeBody(_ configuration: AINoticeConfiguration) -> some View {
9-
HStack(spacing: 8) {
9+
HStack(alignment: .firstTextBaseline, spacing: 8) {
1010
if configuration.viewAlignment == .center {
1111
Spacer()
1212
}

Sources/FioriSwiftUICore/_FioriStyles/BannerMessageStyle.fiori.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public struct BannerMessageBaseStyle: BannerMessageStyle {
2424
VStack(spacing: 0) {
2525
configuration.topDivider.frame(height: 4)
2626
HStack {
27-
HStack(spacing: 6, content: {
27+
HStack(alignment: .firstTextBaseline, spacing: 6, content: {
2828
switch configuration.alignment {
2929
case .leading:
3030
configuration.icon

0 commit comments

Comments
 (0)