Skip to content

Commit 8357eee

Browse files
authored
Merge pull request #49 from ljn917/master
Resolve #39: Potential memory leak in Model::read()
2 parents 8563379 + 00e4509 commit 8357eee

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/Model.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -146,9 +146,9 @@ TF_Buffer *Model::read(const std::string& filename) {
146146
file.seekg (0, std::ios::beg);
147147

148148
// Read
149-
auto data = new char [size];
149+
auto data = std::make_unique<char[]>(size);
150150
file.seekg (0, std::ios::beg);
151-
file.read (data, size);
151+
file.read (data.get(), size);
152152

153153
// Error reading the file
154154
if (!file) {
@@ -158,11 +158,10 @@ TF_Buffer *Model::read(const std::string& filename) {
158158

159159

160160
// Create tensorflow buffer from read data
161-
TF_Buffer* buffer = TF_NewBufferFromString(data, size);
161+
TF_Buffer* buffer = TF_NewBufferFromString(data.get(), size);
162162

163163
// Close file and remove data
164164
file.close();
165-
delete[] data;
166165

167166
return buffer;
168167
}

0 commit comments

Comments
 (0)