From 7b53898775a57689a685c4fdb222b431978866be Mon Sep 17 00:00:00 2001 From: Jan Molak <1089173+jan-molak@users.noreply.github.com> Date: Wed, 19 Nov 2025 21:58:24 +0000 Subject: [PATCH 1/4] ci(github): use the serenity-js docker container for playwright --- .github/workflows/main.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index ae7782983..e4e0f1927 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -11,6 +11,8 @@ jobs: test: timeout-minutes: 60 runs-on: ubuntu-latest + container: + image: ghcr.io/serenity-js/playwright:v1.56.1-noble steps: - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5 - uses: actions/setup-node@v6 From 615dfc9a72f17d77ad3018fa64d0f641e057c5cc Mon Sep 17 00:00:00 2001 From: Jan Molak <1089173+jan-molak@users.noreply.github.com> Date: Wed, 19 Nov 2025 22:03:34 +0000 Subject: [PATCH 2/4] ci(github): removed playwright browsers installation step as it's no longer necessary --- .github/workflows/main.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index e4e0f1927..74cfbc998 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -24,8 +24,6 @@ jobs: java-version: '17' - name: Setup Node Modules uses: bahmutov/npm-install@v1 - - name: Install Playwright Browsers - run: npx playwright install --with-deps - name: Run Playwright tests run: npm test - uses: actions/upload-artifact@v5 From 1c9014dd2433982d9f5d258a6dff3ba05be7938a Mon Sep 17 00:00:00 2001 From: Jan Molak <1089173+jan-molak@users.noreply.github.com> Date: Wed, 19 Nov 2025 22:10:22 +0000 Subject: [PATCH 3/4] ci(github): removed java and node.js setup steps as the new image comes with both --- .github/workflows/main.yml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 74cfbc998..559ffa615 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -15,13 +15,6 @@ jobs: image: ghcr.io/serenity-js/playwright:v1.56.1-noble steps: - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5 - - uses: actions/setup-node@v6 - with: - node-version: '22.21.1' - - uses: actions/setup-java@v5 - with: - distribution: 'temurin' - java-version: '17' - name: Setup Node Modules uses: bahmutov/npm-install@v1 - name: Run Playwright tests From d2fa8922529d45fcaabdc4ceb0da20499192bbaa Mon Sep 17 00:00:00 2001 From: Jan Molak <1089173+jan-molak@users.noreply.github.com> Date: Wed, 19 Nov 2025 22:13:36 +0000 Subject: [PATCH 4/4] fix(node): dropped support for the EOL Node 18, added support for Node 24 --- .github/workflows/main.yml | 3 +++ package.json | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 559ffa615..51b216ee1 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -15,6 +15,9 @@ jobs: image: ghcr.io/serenity-js/playwright:v1.56.1-noble steps: - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5 + - uses: actions/setup-node@v6 + with: + node-version: '22.21.1' - name: Setup Node Modules uses: bahmutov/npm-install@v1 - name: Run Playwright tests diff --git a/package.json b/package.json index acb16335a..c5db3d3ea 100644 --- a/package.json +++ b/package.json @@ -30,7 +30,7 @@ }, "homepage": "https://serenity-js.org", "engines": { - "node": "^18.12 || ^20 || ^22" + "node": "^20 || ^22 || ^24" }, "dependencies": { "@playwright/test": "1.56.1",