chore: fixing lint

Author: KimiWu123

Cargo.toml

@@ -19,7 +19,6 @@ tokio = { version = "1", features = ["full"] }
 ark-ec = { version = "=0.5.0", default-features = false }
 ark-ed-on-bn254 = { version = "=0.5.0", default-features = false }
 ark-ff = { version = "=0.5.0", default-features = false }
-# ark-bn254 = "0.5.0"
 
 # zk-kit
 zk-kit-lean-imt = { git = "https://github.com/brech1/zk-kit.rust", package = "zk-kit-lean-imt", branch = "feat/generic-tree" }

src/proof.rs

@@ -62,14 +62,14 @@ impl Proof {
         merkle_tree_depth: u16,
     ) -> Result<SemaphoreProof> {
         // check tree depth
-        if merkle_tree_depth < MIN_TREE_DEPTH || merkle_tree_depth > MAX_TREE_DEPTH {
+        if !(MIN_TREE_DEPTH..=MAX_TREE_DEPTH).contains(&merkle_tree_depth) {
             bail!(format!(
                 "The tree depth must be a number between {} and {}",
                 MIN_TREE_DEPTH, MAX_TREE_DEPTH
             ));
         }
 
-        let merkle_proof = group.merkle_proof(&to_element(identity.commitment().clone()));
+        let merkle_proof = group.merkle_proof(&to_element(*identity.commitment()));
         let merkle_proof_length = merkle_proof.siblings.len();
 
         // The index must be converted to a list of indices, 1 for each tree level.
@@ -80,7 +80,7 @@ impl Proof {
             merkle_proof_indices.push((merkle_proof.index >> i) & 1);
 
             if let Some(sibling) = merkle_proof.siblings.get(i as usize) {
-                merkle_proof_siblings.push(sibling.clone());
+                merkle_proof_siblings.push(*sibling);
             } else {
                 merkle_proof_siblings.push(EMPTY_ELEMENT);
             }

src/utils.rs

@@ -22,7 +22,7 @@ pub fn to_big_uint(str: &String) -> BigUint {
     let bytes = str.as_bytes();
     assert!(bytes.len() <= 32, "BigUint too large: exceeds 32 bytes");
     let mut fixed_bytes = [0u8; 32];
-    fixed_bytes[0..bytes.len()].copy_from_slice(&bytes);
+    fixed_bytes[0..bytes.len()].copy_from_slice(bytes);
     BigUint::from_bytes_be(&fixed_bytes)
 }