Squashed 'libbitcoinkernel-sys/bitcoin/' changes from 5c5704e73079..b354d1ce5c47

b354d1ce5c47 Merge bitcoin/bitcoin#33820: kernel: trim Chain interface
a4e96cae7d3d Merge bitcoin/bitcoin#33042: refactor: inline constant return values from `dbwrapper` write methods
8c2710b0415f Merge bitcoin/bitcoin#32517: rpc: add "ischange: true" to decoded tx outputs in wallet gettransaction response
1fe851a4781a Merge bitcoin/bitcoin#32180: p2p: Advance pindexLastCommonBlock early after connecting blocks
5f0303b93fa7 Merge bitcoin/bitcoin#33443: log: reduce excessive "rolling back/forward" messages during block replay
f4903dddc9ea Merge bitcoin/bitcoin#33433: Bugfix: QA: rpc_bind: Skip nonloopback test if no such address is found
06e9458869ee Merge bitcoin/bitcoin#32856: Update `minisketch` subtree
66978a1a9537 kernel: remove btck_chain_get_tip
4dd7e6dc48ed kernel: remove btck_chain_get_genesis
490cb056f651 Merge bitcoin/bitcoin#33785: util: Allow `Assert` (et al.) in contexts without __func__
dcd0099a765e Merge bitcoin/bitcoin#33826: scripted-diff: Remove obsolete comment
01adbbcd9c50 Merge bitcoin/bitcoin#33827: doc: Correct `pkgin` command usage on NetBSD
eec21bc7c8bf Merge bitcoin/bitcoin#33536: doc: reference fuzz coverage steps in quick-start
035f934e02f9 Merge bitcoin/bitcoin#33823: ci: Use cmake --preset=dev-mode in test-each-commit task
ddd2afac1073 Merge bitcoin/bitcoin#33676: interfaces: enable cancelling running `waitNext` calls
dee7eec64389 doc: mention coverage build in quickstart section
0698c6b494de doc: Correct `pkgin` command usage on NetBSD
36724205fc1f scripted-diff: Remove obsolete comment
ca1ce52a0f1e Merge bitcoin/bitcoin#33825: refactor: Add missing include in bitcoinkernel_wrapper.h
fa1e8d8bad92 refactor: Add missing include in bitcoinkernel_wrapper.h
fa6db67369fb ci: [refactor] Extract build_dir constant in ci-test-each-commit-exec.py
fa95e6cdc1c5 ci: Use cmake --preset=dev-mode in test-each-commit task
513a0da2e0c8 Merge bitcoin/bitcoin#33818: ci: Extend tidy job to cover kernel code
5d0a40d607d4 ci: Extend tidy job to cover kernel code
93e79181da8c Merge bitcoin/bitcoin#33786: script: remove dead code in `CountWitnessSigOps`
3c4bec62239d Merge bitcoin/bitcoin#33782: test: remove obsolete `get_{key,multisig}` helpers from wallet_util.py
4b12beedaef5 Merge bitcoin/bitcoin#33793: test: move create_malleated_version() to messages.py for reuse
0b45e6db1058 Merge bitcoin/bitcoin#33789: doc: add cmake help option in Windows build docs
2b9c3511986b Merge bitcoin/bitcoin#33768: refactor: remove dead branches in `SingletonClusterImpl`
fad6efd3bef1 refactor: Use STR_INTERNAL_BUG macro where possible
fada379589a1 doc: Remove unused bugprone-lambda-function-name suppression
2bd155e6ee7e test: move create_malleated_version() to messages.py for reuse
9577daa3b88a doc: Add cmake help option in Windows build instructions
fae1d99651e2 refactor: Use const reference to std::source_location
fa5fbcd61563 util: Allow Assert() in contexts without __func__
24bcad3d4df5 refactor: remove dead code in `CountWitnessSigOps`
ec8516ceb756 test: remove obsolete `get_{key,multisig}` helpers from wallet_util.py
2d23820ee116 refactor: remove dead branches in `SingletonClusterImpl`
060bb5550824 rpc: add decoded tx details to gettransaction with extra wallet fields
ad1c3bdba547 [move only] move DecodeTxDoc() to a common util file for sharing
d633db541664 rpc: add "ischange: true" in wallet gettransaction decoded tx output
dcb56fd4cb59 interfaces: add interruptWait method
c235aa468b0d Update minisketch subtree to latest upstream
4543a3bde26f Squashed 'src/minisketch/' changes from ea8f66b1ea..d1bd01e189
01cc20f3307c test: improve coverage for a resolved stalling situation
9af6daf07ed0 test: remove magic number when checking for blocks that have arrived
3069d66dcac0 p2p: During block download, adjust pindexLastCommonBlock better
1fc7a81f1f5f log: reduce excessive messages during block replay
79b4c276e7b9 Bugfix: QA: rpc_bind: Skip nonloopback test if no such address is found
743abbcbde9e refactor: inline constant return value of `BlockTreeDB::WriteBatchSync` and `BlockManager::WriteBlockIndexDB` and `BlockTreeDB::WriteFlag`
e030240e9094 refactor: inline constant return value of `CDBWrapper::Erase` and `BlockTreeDB::WriteReindexing`
cdab9480e9e3 refactor: inline constant return value of `CDBWrapper::Write`
d1847cf5b5af refactor: inline constant return value of `TxIndex::DB::WriteTxs`
50b63a5698e5 refactor: inline constant return value of `CDBWrapper::WriteBatch`

git-subtree-dir: libbitcoinkernel-sys/bitcoin
git-subtree-split: b354d1ce5c47997aa2f93910e05c0f8daa8736eb

Author: sedited

.github/ci-test-each-commit-exec.py

@@ -21,11 +21,12 @@ def main():
     run(["git", "log", "-1"])
 
     num_procs = int(run(["nproc"], stdout=subprocess.PIPE).stdout)
+    build_dir = "ci_build"
 
     run([
         "cmake",
         "-B",
-        "build",
+        build_dir,
         "-Werror=dev",
         # Use clang++, because it is a bit faster and uses less memory than g++
         "-DCMAKE_C_COMPILER=clang",
@@ -37,28 +38,23 @@ def main():
         "-DAPPEND_CFLAGS='-O3 -g2'",
         "-DCMAKE_BUILD_TYPE=Debug",
         "-DWERROR=ON",
-        "-DWITH_ZMQ=ON",
-        "-DBUILD_GUI=ON",
-        "-DBUILD_BENCH=ON",
-        "-DBUILD_FUZZ_BINARY=ON",
-        "-DWITH_USDT=ON",
-        "-DBUILD_KERNEL_LIB=ON",
-        "-DBUILD_KERNEL_TEST=ON",
+        "--preset=dev-mode",
+        # Tolerate unused member functions in intermediate commits in a pull request
         "-DCMAKE_CXX_FLAGS=-Wno-error=unused-member-function",
     ])
-    run(["cmake", "--build", "build", "-j", str(num_procs)])
+    run(["cmake", "--build", build_dir, "-j", str(num_procs)])
     run([
         "ctest",
         "--output-on-failure",
         "--stop-on-failure",
         "--test-dir",
-        "build",
+        build_dir,
         "-j",
         str(num_procs),
     ])
     run([
         sys.executable,
-        "./build/test/functional/test_runner.py",
+        f"./{build_dir}/test/functional/test_runner.py",
         "-j",
         str(num_procs * 2),
         "--combinedlogslen=99999999",

ci/test/00_setup_env_arm.sh

@@ -19,4 +19,10 @@ export GOAL="install"
 export CI_LIMIT_STACK_SIZE=1
 # -Wno-psabi is to disable ABI warnings: "note: parameter passing for argument of type ... changed in GCC 7.1"
 # This could be removed once the ABI change warning does not show up by default
-export BITCOIN_CONFIG="-DREDUCE_EXPORTS=ON -DCMAKE_CXX_FLAGS='-Wno-psabi -Wno-error=maybe-uninitialized'"
+#
+# -Wno-error=dangling-reference helps to work around a GCC 13.1 false-positive,
+# fixed in later versions.
+export BITCOIN_CONFIG=" \
+  -DREDUCE_EXPORTS=ON \
+  -DCMAKE_CXX_FLAGS='-Wno-psabi -Wno-error=dangling-reference -Wno-error=maybe-uninitialized' \
+"

ci/test/00_setup_env_native_tidy.sh

@@ -19,7 +19,7 @@ export RUN_CHECK_DEPS=true
 export RUN_TIDY=true
 export GOAL="install"
 export BITCOIN_CONFIG="\
- -DWITH_ZMQ=ON -DBUILD_GUI=ON -DBUILD_BENCH=ON -DWITH_USDT=ON \
+ --preset dev-mode \
  -DCMAKE_C_COMPILER=clang-${TIDY_LLVM_V} \
  -DCMAKE_CXX_COMPILER=clang++-${TIDY_LLVM_V} \
  -DCMAKE_C_FLAGS_RELWITHDEBINFO='-O0 -g0' \

ci/test/00_setup_env_win64.sh

@@ -13,5 +13,8 @@ export PACKAGES="g++-mingw-w64-x86-64-posix nsis"
 export RUN_UNIT_TESTS=false
 export RUN_FUNCTIONAL_TESTS=false
 export GOAL="deploy"
+# -Wno-error=dangling-reference helps to work around a GCC 13.1 false-positive,
+# fixed in later versions.
 export BITCOIN_CONFIG="-DREDUCE_EXPORTS=ON -DBUILD_GUI_TESTS=OFF -DBUILD_KERNEL_LIB=ON -DBUILD_KERNEL_TEST=ON \
--DCMAKE_CXX_FLAGS='-Wno-error=maybe-uninitialized'"
+  -DCMAKE_CXX_FLAGS='-Wno-error=dangling-reference -Wno-error=maybe-uninitialized' \
+"

doc/build-freebsd.md

@@ -101,5 +101,5 @@ cmake -B build -DENABLE_WALLET=OFF
 
 ```bash
 cmake --build build     # Append "-j N" for N parallel jobs.
-ctest --test-dir build  # Append "-j N" for N parallel tests. Some tests are disabled if Python 3 is not available.
+ctest --test-dir build  # Append "-j N" for N parallel tests.
 ```

doc/build-netbsd.md

@@ -34,15 +34,15 @@ cmake -B build
 SQLite is required for the wallet:
 
 ```bash
-pkgin sqlite3
+pkgin install sqlite3
 ```
 
 To build Bitcoin Core without the wallet, use `-DENABLE_WALLET=OFF`.
 
 Cap'n Proto is needed for IPC functionality (see [multiprocess.md](multiprocess.md)):
 
 ```bash
-pkgin capnproto
+pkgin install capnproto
 ```
 
 Compile with `-DENABLE_IPC=OFF` if you do not need IPC functionality.
@@ -84,7 +84,7 @@ Otherwise, if you don't need QR encoding support, use the `-DWITH_QRENCODE=OFF`
 
 Bitcoin Core can provide notifications via ZeroMQ. If the package is installed, support will be compiled in.
 ```bash
-pkgin zeromq
+pkgin install zeromq
 ```
 
 #### Test Suite Dependencies
@@ -115,5 +115,5 @@ Build and run the tests:
 
 ```bash
 cmake --build build     # Append "-j N" for N parallel jobs.
-ctest --test-dir build  # Append "-j N" for N parallel tests. Some tests are disabled if Python 3 is not available.
+ctest --test-dir build  # Append "-j N" for N parallel tests.
 ```

doc/build-openbsd.md

@@ -93,7 +93,7 @@ Run `cmake -B build -LH` to see the full list of available options.
 
 ```bash
 cmake --build build     # Append "-j N" for N parallel jobs.
-ctest --test-dir build  # Append "-j N" for N parallel tests. Some tests are disabled if Python 3 is not available.
+ctest --test-dir build  # Append "-j N" for N parallel tests.
 ```
 
 ## Resource limits

doc/build-osx.md

@@ -170,7 +170,7 @@ Run the following in your terminal to compile Bitcoin Core:
 
 ``` bash
 cmake --build build     # Append "-j N" here for N parallel jobs.
-ctest --test-dir build  # Append "-j N" for N parallel tests. Some tests are disabled if Python 3 is not available.
+ctest --test-dir build  # Append "-j N" for N parallel tests.
 ```
 
 ### 3. Deploy (optional)

doc/build-windows-msvc.md

@@ -50,12 +50,14 @@ CMake will put the resulting object files, libraries, and executables into a ded
 
 In the following instructions, the "Debug" configuration can be specified instead of the "Release" one.
 
+Run `cmake -B build -LH` to see the full list of available options.
+
 ### 4. Building with Static Linking with GUI
 
 ```
 cmake -B build --preset vs2022-static          # It might take a while if the vcpkg binary cache is unpopulated or invalidated.
 cmake --build build --config Release           # Append "-j N" for N parallel jobs.
-ctest --test-dir build --build-config Release  # Append "-j N" for N parallel tests. Some tests are disabled if Python 3 is not available.
+ctest --test-dir build --build-config Release  # Append "-j N" for N parallel tests.
 cmake --install build --config Release         # Optional.
 ```
 
@@ -64,7 +66,7 @@ cmake --install build --config Release         # Optional.
 ```
 cmake -B build --preset vs2022 -DBUILD_GUI=OFF # It might take a while if the vcpkg binary cache is unpopulated or invalidated.
 cmake --build build --config Release           # Append "-j N" for N parallel jobs.
-ctest --test-dir build --build-config Release  # Append "-j N" for N parallel tests. Some tests are disabled if Python 3 is not available.
+ctest --test-dir build --build-config Release  # Append "-j N" for N parallel tests.
 ```
 
 ### 6. vcpkg-specific Issues and Workarounds

doc/build-windows.md

@@ -49,6 +49,9 @@ Build using:
 
     gmake -C depends HOST=x86_64-w64-mingw32  # Append "-j N" for N parallel jobs.
     cmake -B build --toolchain depends/x86_64-w64-mingw32/toolchain.cmake
+
+Run `cmake -B build -LH` to see the full list of available options.
+
     cmake --build build     # Append "-j N" for N parallel jobs.
 
 ## Depends system