PHPStan level 9 (and final) compatibility.

Author: sebastianluczak

phpstan.neon

@@ -1,10 +1,12 @@
 parameters:
-	level: 8
+	level: 9
 	checkMissingIterableValueType: false
 	checkGenericClassInNonGenericObjectType: false
 	doctrine:
 	    objectManagerLoader: tests/object-manager.php
 	universalObjectCratesClasses:
 	    - RPGFaker\RPGFaker
 	paths:
-		- src
+		- src
+	ignoreErrors:
+	    - '#. but returns mixed.#'

src/Model/Creature/AbstractCreature.php

@@ -43,7 +43,9 @@ public function __construct()
         $nameFaker = new RPGFaker(['count' => 1]);
         $this->faker = FakerFactory::create('ja_JP');
         $this->loot = new InventoryBag();
-        $this->rawName = $nameFaker->name;
+        if (is_string($generatedName = $nameFaker->name)) {
+            $this->rawName = $generatedName;
+        }
     }
 
     public function getExperience(): int

src/Repository/LeaderboardRepository.php

@@ -19,9 +19,6 @@ public function __construct(ManagerRegistry $registry)
         parent::__construct($registry, Leaderboard::class);
     }
 
-    /**
-     * @return array|Leaderboard[]
-     */
     public function getBest(): array
     {
         $query = $this->createQueryBuilder('l')

src/Service/LeaderboardService.php

@@ -20,9 +20,6 @@ public function __construct(LeaderboardRepository $leaderboardRepository, Entity
         $this->em = $em;
     }
 
-    /**
-     * @return Leaderboard[]|array
-     */
     public function getBestScores(): array
     {
         try {

src/Service/PlayerService.php

@@ -15,7 +15,11 @@ class PlayerService
     public function __construct()
     {
         $rpgFaker = new RPGFaker(['count' => 1, 'race' => 'human']);
-        $this->player = new Player($rpgFaker->name, new PlayerCoordinates(0, 0));
+        if (is_string($generatedName = $rpgFaker->name)) {
+            $this->player = new Player($generatedName, new PlayerCoordinates(0, 0));
+        } else {
+            throw new \LogicException('Initialization of Player failed due to bug in name generator.');
+        }
     }
 
     public function getPlayer(): PlayerInterface

src/Service/YamlLevelParserService.php

@@ -21,7 +21,7 @@ protected function processCurrentYamlFile(): void
             throw new Exception('Not file specified');
         }
 
-        $this->yamlProcessed = Yaml::parseFile($this->yamlFilePath);
+        $this->yamlProcessed = (array) Yaml::parseFile($this->yamlFilePath);
     }
 
     public function setYamlFilePath(string $yamlFilePath): void