Skip to content

Commit c436e80

Browse files
Removing redundant local variables
1 parent 667ba7b commit c436e80

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

monitoring.tf

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
locals {
2-
enable_dead_letters_monitoring = var.enabled_dead_letters_monitoring
3-
dl_warning = var.dl_warning
4-
dl_critical = var.dl_critical
52
dlq_to_monitor = [
63
local.enable_group_events ? var.sqs_fifo_DL_queue_name : var.sqs_queue_name_dl,
74
var.enable_glue_create ? var.glue_create_config.sqs_queue_name_dl : "",
@@ -10,7 +7,7 @@ locals {
107
}
118

129
resource "datadog_monitor" "dead_letters_monitor" {
13-
for_each = local.enable_dead_letters_monitoring ? toset(local.dlq_to_monitor) : []
10+
for_each = var.enable_dead_letters_monitoring ? toset(local.dlq_to_monitor) : []
1411

1512
type = "metric alert"
1613
name = "${each.key}-monitor"
@@ -22,9 +19,9 @@ resource "datadog_monitor" "dead_letters_monitor" {
2219
query = "avg(last_1h):avg:aws.sqs.approximate_number_of_messages_visible{queuename:${each.key}} > ${var.dl_critical}"
2320

2421
monitor_thresholds {
25-
warning = local.dl_warning
26-
critical = local.dl_critical
27-
ok = local.dl_ok
22+
warning = var.dl_warning
23+
critical = var.dl_critical
24+
ok = var.dl_ok
2825
}
2926

3027
notify_no_data = false

0 commit comments

Comments
 (0)