Merge pull request #24 from scribd/PE-5493-oxbow-fix

kuntalkumarbasu · web-flow · commit 5beb00b582f1 · 2024-03-28T16:14:06.000-04:00
PE-5493:fix:ensuring no resource when enable auto tagging is false
diff --git a/autotagging.tf b/autotagging.tf
@@ -50,7 +50,7 @@ resource "aws_sqs_queue" "auto_tagging" {
 }
 
 resource "aws_sns_topic_subscription" "auto_tagging" {
-  count = var.sns_topic_arn == "" ? 0 : 1
+  count = var.enable_auto_tagging == true ? var.sns_topic_arn == "" ? 0 : 1 : 0
 
   topic_arn = var.sns_topic_arn
   protocol  = "sqs"
@@ -99,7 +99,7 @@ data "aws_iam_policy_document" "auto_tagging_sqs" {
 }
 
 data "aws_iam_policy_document" "auto_tagging_sns" {
-  count = var.sns_topic_arn == "" ? 0 : 1
+  count = var.enable_auto_tagging == true ? var.sns_topic_arn == "" ? 0 : 1 : 0
 
   statement {
     effect = "Allow"

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ resource "aws_sqs_queue" "auto_tagging" {`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`resource "aws_sns_topic_subscription" "auto_tagging" {`
`53`		`- count = var.sns_topic_arn == "" ? 0 : 1`
	`53`	`+ count = var.enable_auto_tagging == true ? var.sns_topic_arn == "" ? 0 : 1 : 0`
`54`	`54`
`55`	`55`	`topic_arn = var.sns_topic_arn`
`56`	`56`	`protocol = "sqs"`
`@@ -99,7 +99,7 @@ data "aws_iam_policy_document" "auto_tagging_sqs" {`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`data "aws_iam_policy_document" "auto_tagging_sns" {`
`102`		`- count = var.sns_topic_arn == "" ? 0 : 1`
	`102`	`+ count = var.enable_auto_tagging == true ? var.sns_topic_arn == "" ? 0 : 1 : 0`
`103`	`103`
`104`	`104`	`statement {`
`105`	`105`	`effect = "Allow"`