Remove lobby creator

Author: Bios-Marcel

internal/game/data.go

@@ -40,10 +40,6 @@ type Lobby struct {
 	// Owner references the Player that currently owns the lobby.
 	// Meaning this player has rights to restart or change certain settings.
 	Owner *Player
-	// creator is the player that opened a lobby. Initially creator and owner
-	// are set to the same player. While the owner can change throughout the
-	// game, the creator can't.
-	creator *Player
 	// ScoreCalculation decides how scores for both guessers and drawers are
 	// determined.
 	ScoreCalculation ScoreCalculation

internal/game/lobby.go

@@ -526,16 +526,6 @@ func calculateVotesNeededToKick(playerToKick *Player, lobby *Lobby) int {
 		return 2
 	}
 
-	if playerToKick == lobby.creator {
-		// We don't want to allow people to kick the creator, as this could
-		// potentially annoy certain creators. For example a streamer playing
-		// a game with viewers could get trolled this way. Just one
-		// hypothetical scenario, I am sure there are more ;)
-
-		// All players excluding the owner themselves.
-		return connectedPlayerCount - 1
-	}
-
 	// If the amount of players equals an even number, such as 6, we will always
 	// need half of that. If the amount is uneven, we'll get a floored result.
 	// therefore we always add one to the amount.
@@ -982,7 +972,6 @@ func CreateLobby(
 
 	player := lobby.JoinPlayer(playerName)
 	lobby.Owner = player
-	lobby.creator = player
 
 	return player, lobby, nil
 }

internal/game/lobby_test.go

@@ -17,8 +17,7 @@ import (
 func createLobbyWithDemoPlayers(playercount int) *Lobby {
 	owner := &Player{}
 	lobby := &Lobby{
-		Owner:   owner,
-		creator: owner,
+		Owner: owner,
 	}
 	for range playercount {
 		lobby.players = append(lobby.players, &Player{
@@ -279,7 +278,6 @@ func Test_wordSelectionEvent(t *testing.T) {
 	drawer := lobby.JoinPlayer("Drawer")
 	drawer.Connected = true
 	lobby.Owner = drawer
-	lobby.creator = drawer
 
 	if err := lobby.HandleEvent(EventTypeStart, nil, drawer); err != nil {
 		t.Errorf("Couldn't start lobby: %s", err)
@@ -346,7 +344,6 @@ func Test_kickDrawer(t *testing.T) {
 	marcel := lobby.JoinPlayer("marcel")
 	marcel.Connected = true
 	lobby.Owner = marcel
-	lobby.creator = marcel
 
 	kevin := lobby.JoinPlayer("kevin")
 	kevin.Connected = true