Merge pull request #30 from scivisum/bug/RD-37283_startDateTime_sometimes_a_string

Bug/rd 37283 start date time sometimes a string

Author: erustusagutu

browserdebuggertools/exceptions.py

@@ -48,3 +48,7 @@ class MaxRetriesException(DevToolsException):
 
 class UnknownError(ProtocolError):
     pass
+
+
+class InvalidParametersError(ProtocolError):
+    pass

browserdebuggertools/sockethandler.py

@@ -15,7 +15,8 @@
 from browserdebuggertools.exceptions import (
     DevToolsException, ResultNotFoundError, TabNotFoundError, MaxRetriesException,
     DevToolsTimeoutException, DomainNotEnabledError,
-    MethodNotFoundError, UnknownError, ResourceNotFoundError, TimerException
+    MethodNotFoundError, UnknownError, ResourceNotFoundError, TimerException,
+    InvalidParametersError
 )
 
 
@@ -239,6 +240,8 @@ def execute(self, domain_name, method_name, params=None):
                 raise ResourceNotFoundError(message)
             if code == -32601:
                 raise MethodNotFoundError(message)
+            if code == -32602:
+                raise InvalidParametersError(message)
             raise UnknownError("DevTools Protocol error code %s: %s" % (code, message))
         return result
 

setup.py

@@ -12,7 +12,7 @@
 
 setup(
     name="browserdebuggertools",
-    version="5.3.0",
+    version="5.4.0rc1",
     packages=PACKAGES,
     install_requires=requires,
     license="GNU General Public License v3",

tests/unittests/test_sockethandler.py

@@ -6,7 +6,7 @@
 
 from browserdebuggertools.exceptions import (
     DevToolsException, ResultNotFoundError, TabNotFoundError,
-    DomainNotEnabledError, DevToolsTimeoutException, MethodNotFoundError
+    DomainNotEnabledError, DevToolsTimeoutException, MethodNotFoundError, InvalidParametersError
 )
 from browserdebuggertools.sockethandler import SocketHandler
 
@@ -229,7 +229,7 @@ def test_no_result(self):
 @patch(MODULE_PATH + "websocket.send", MagicMock())
 class Test_SocketHandler_execute(SocketHandlerTest):
 
-    def test(self):
+    def test_ok(self):
 
         domain = "Page"
         method = "navigate"
@@ -246,6 +246,16 @@ def test(self):
             "method": "%s.%s" % (domain, method), "params": {}
         })
 
+    @patch(MODULE_PATH + "SocketHandler._execute", new=MagicMock())
+    def test_error(self):
+
+        self.socket_handler._wait_for_result = MagicMock(
+            return_value={"error": {"code": -32602, "message": "Invalid interceptionId"}}
+        )
+
+        with self.assertRaises(InvalidParametersError):
+            self.socket_handler.execute(MagicMock(), MagicMock(), None)
+
 
 class Test_SocketHandler_add_domain(SocketHandlerTest):