Skip to content

Commit 7c3496a

Browse files
authored
Test cubes overlap cleaned up (#232)
`test_cubes_overlap` mistakenly called set union instead of set intersecrtion. Added a short docstring explaining what the test does and made a small stylistic change.
1 parent 2a17839 commit 7c3496a

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

test/test_coverer.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ def test_entries_even(self, CoverClass):
4343
assert len(entries) >= 2
4444

4545
def test_cubes_overlap(self, CoverClass):
46+
"""A ten element cover of 20 evenly spaced elements should have adjacent overlap"""
4647
data = np.arange(40).reshape(20, 2)
4748

4849
cover = CoverClass(n_cubes=10)
@@ -51,11 +52,11 @@ def test_cubes_overlap(self, CoverClass):
5152
entries = []
5253
for cube in cubes:
5354
# turn singleton lists into individual elements
54-
res = [i[0] for i in cover.transform_single(data, cube)]
55+
res = set(cover.transform_single(data, cube)[:, 0])
5556
entries.append(res)
5657

57-
for i, j in zip(range(9), range(1, 10)):
58-
assert set(entries[i]).union(set(entries[j]))
58+
for s, t in zip(entries, entries[1:]):
59+
assert s.intersection(t)
5960

6061
def test_perc_overlap(self, CoverClass):
6162
"""

0 commit comments

Comments
 (0)