From caec38e872ae7793ac8df9ecf503d9713864a44d Mon Sep 17 00:00:00 2001 From: solegalli Date: Fri, 7 Nov 2025 09:44:24 -0500 Subject: [PATCH 01/10] add test workflow --- .github/workflows/test_package.yml | 33 ++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 .github/workflows/test_package.yml diff --git a/.github/workflows/test_package.yml b/.github/workflows/test_package.yml new file mode 100644 index 0000000..269b335 --- /dev/null +++ b/.github/workflows/test_package.yml @@ -0,0 +1,33 @@ +name: Python boruta + +on: + push: + branches: [ "master" ] + pull_request: + branches: [ "master" ] + +jobs: + build: + + runs-on: ubuntu-latest + strategy: + matrix: + python-version: ["3.10", "3.11", "3.12", "3.13"] + + steps: + - uses: actions/checkout@v5 + - name: Set up Python ${{ matrix.python-version }} + uses: actions/setup-python@v5 + with: + python-version: ${{ matrix.python-version }} + # You can test your matrix by printing the current Python version + - name: Display Python version + run: python -c "import sys; print(sys.version)" + - name: Install dependencies + run: | + python -m pip install --upgrade pip + pip install -r requirements_test.txt + - name: Test with pytest + run: | + pip install pytest pytest-cov + pytest test_boruta.py \ No newline at end of file From f3272eff02c6f7936bfd9aad99f22db19a3b7113 Mon Sep 17 00:00:00 2001 From: solegalli Date: Fri, 7 Nov 2025 09:47:51 -0500 Subject: [PATCH 02/10] edit workflow --- .github/workflows/test_package.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test_package.yml b/.github/workflows/test_package.yml index 269b335..39471c8 100644 --- a/.github/workflows/test_package.yml +++ b/.github/workflows/test_package.yml @@ -1,4 +1,4 @@ -name: Python boruta +name: Test boruta on: push: @@ -26,8 +26,9 @@ jobs: - name: Install dependencies run: | python -m pip install --upgrade pip + pip install -r requirements.txt pip install -r requirements_test.txt - name: Test with pytest run: | - pip install pytest pytest-cov + pip install pytest pytest test_boruta.py \ No newline at end of file From 62ff594ae573a78002fcf9f1a0e7a06db0023a38 Mon Sep 17 00:00:00 2001 From: solegalli Date: Fri, 7 Nov 2025 09:55:27 -0500 Subject: [PATCH 03/10] add requirements file --- requirements.txt | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 requirements.txt diff --git a/requirements.txt b/requirements.txt new file mode 100644 index 0000000..cc0cf5b --- /dev/null +++ b/requirements.txt @@ -0,0 +1,3 @@ +numpy>=1.18.2 +pandas>=2.2.0 +scikit-learn>=1.4.0 \ No newline at end of file From 051ffaa3823ee4f02d96b4f9f31af2d9145f5d23 Mon Sep 17 00:00:00 2001 From: solegalli Date: Fri, 7 Nov 2025 09:58:47 -0500 Subject: [PATCH 04/10] fix typo in wirkflow --- .github/workflows/test_package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test_package.yml b/.github/workflows/test_package.yml index 39471c8..de7dd63 100644 --- a/.github/workflows/test_package.yml +++ b/.github/workflows/test_package.yml @@ -27,7 +27,7 @@ jobs: run: | python -m pip install --upgrade pip pip install -r requirements.txt - pip install -r requirements_test.txt + pip install -r test_requirements.txt - name: Test with pytest run: | pip install pytest From 98b8bcf5def4d74eb73596251c9724bdfabaac8a Mon Sep 17 00:00:00 2001 From: solegalli Date: Fri, 7 Nov 2025 10:31:25 -0500 Subject: [PATCH 05/10] modified test syntax --- .github/workflows/test_package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test_package.yml b/.github/workflows/test_package.yml index de7dd63..ca9b0ed 100644 --- a/.github/workflows/test_package.yml +++ b/.github/workflows/test_package.yml @@ -31,4 +31,4 @@ jobs: - name: Test with pytest run: | pip install pytest - pytest test_boruta.py \ No newline at end of file + pytest \ No newline at end of file From 30946a351b03da809d8f1016462248457284de7f Mon Sep 17 00:00:00 2001 From: solegalli Date: Fri, 7 Nov 2025 16:59:04 -0500 Subject: [PATCH 06/10] add tests for different sklearn versions --- .github/workflows/test_package.yml | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test_package.yml b/.github/workflows/test_package.yml index ca9b0ed..8a6ac75 100644 --- a/.github/workflows/test_package.yml +++ b/.github/workflows/test_package.yml @@ -12,22 +12,39 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - python-version: ["3.10", "3.11", "3.12", "3.13"] + include: + - python-version: "3.10" + - python-version: "3.12" + - python-version: "3.13" + # Add three variants for Python 3.11 with different sklearn versions + - python-version: "3.11" + sklearn-version: "1.5.2" + - python-version: "3.11" + sklearn-version: "1.6.1" + - python-version: "3.11" + sklearn-version: "1.7.0" steps: - uses: actions/checkout@v5 + - name: Set up Python ${{ matrix.python-version }} uses: actions/setup-python@v5 with: python-version: ${{ matrix.python-version }} - # You can test your matrix by printing the current Python version + - name: Display Python version run: python -c "import sys; print(sys.version)" + - name: Install dependencies run: | python -m pip install --upgrade pip pip install -r requirements.txt pip install -r test_requirements.txt + # Only install specific sklearn version if defined in matrix + if [ -n "${{ matrix.sklearn-version }}" ]; then + pip install scikit-learn==${{ matrix.sklearn-version }} + fi + - name: Test with pytest run: | pip install pytest From 6cf1366c6a0f0274904fde894ae5fca90a3bdf07 Mon Sep 17 00:00:00 2001 From: solegalli Date: Fri, 7 Nov 2025 17:07:52 -0500 Subject: [PATCH 07/10] add tests for different numpy versions --- .github/workflows/test_package.yml | 28 +++++++++++++++++++++++++--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test_package.yml b/.github/workflows/test_package.yml index 8a6ac75..34132c1 100644 --- a/.github/workflows/test_package.yml +++ b/.github/workflows/test_package.yml @@ -13,10 +13,12 @@ jobs: strategy: matrix: include: + # Regular Python versions (no special package versions) - python-version: "3.10" - python-version: "3.12" - python-version: "3.13" - # Add three variants for Python 3.11 with different sklearn versions + + # Python 3.11 with different scikit-learn versions - python-version: "3.11" sklearn-version: "1.5.2" - python-version: "3.11" @@ -24,6 +26,18 @@ jobs: - python-version: "3.11" sklearn-version: "1.7.0" + # Python 3.11 with different NumPy versions + - python-version: "3.11" + numpy-version: "1.26.4" + - python-version: "3.11" + numpy-version: "2.0.1" + - python-version: "3.11" + numpy-version: "2.1.1" + - python-version: "3.11" + numpy-version: "2.2.2" + - python-version: "3.11" + numpy-version: "2.3.1" + steps: - uses: actions/checkout@v5 @@ -40,12 +54,20 @@ jobs: python -m pip install --upgrade pip pip install -r requirements.txt pip install -r test_requirements.txt - # Only install specific sklearn version if defined in matrix + + # Install specific scikit-learn version if defined if [ -n "${{ matrix.sklearn-version }}" ]; then + echo "Installing scikit-learn==${{ matrix.sklearn-version }}" pip install scikit-learn==${{ matrix.sklearn-version }} fi + # Install specific NumPy version if defined + if [ -n "${{ matrix.numpy-version }}" ]; then + echo "Installing numpy==${{ matrix.numpy-version }}" + pip install numpy==${{ matrix.numpy-version }} + fi + - name: Test with pytest run: | pip install pytest - pytest \ No newline at end of file + pytest From f1fa2fe1aa2d69bf5224cef7b90a1bdb4b1b2a53 Mon Sep 17 00:00:00 2001 From: solegalli Date: Fri, 7 Nov 2025 17:11:41 -0500 Subject: [PATCH 08/10] add meaningful test names --- .github/workflows/test_package.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test_package.yml b/.github/workflows/test_package.yml index 34132c1..0486d0e 100644 --- a/.github/workflows/test_package.yml +++ b/.github/workflows/test_package.yml @@ -8,8 +8,8 @@ on: jobs: build: - runs-on: ubuntu-latest + strategy: matrix: include: @@ -38,6 +38,11 @@ jobs: - python-version: "3.11" numpy-version: "2.3.1" + name: >- + Python ${{ matrix.python-version }} + ${{ matrix.sklearn-version && format('(scikit-learn {0})', matrix.sklearn-version) || '' }} + ${{ matrix.numpy-version && format('(NumPy {0})', matrix.numpy-version) || '' }} + steps: - uses: actions/checkout@v5 @@ -70,4 +75,4 @@ jobs: - name: Test with pytest run: | pip install pytest - pytest + pytest \ No newline at end of file From fe279cac913debefd2397628ad4eac5858771e29 Mon Sep 17 00:00:00 2001 From: solegalli Date: Fri, 7 Nov 2025 17:23:51 -0500 Subject: [PATCH 09/10] add older sklearn and numpy versions --- .github/workflows/test_package.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/test_package.yml b/.github/workflows/test_package.yml index 0486d0e..0053d2a 100644 --- a/.github/workflows/test_package.yml +++ b/.github/workflows/test_package.yml @@ -19,6 +19,8 @@ jobs: - python-version: "3.13" # Python 3.11 with different scikit-learn versions + - python-version: "3.11" + sklearn-version: "1.4.0" - python-version: "3.11" sklearn-version: "1.5.2" - python-version: "3.11" @@ -27,6 +29,8 @@ jobs: sklearn-version: "1.7.0" # Python 3.11 with different NumPy versions + - python-version: "3.11" + numpy-version: "1.18.2" - python-version: "3.11" numpy-version: "1.26.4" - python-version: "3.11" From 687e0e4e528d7a33e3d287b8b7f3893a7c17a624 Mon Sep 17 00:00:00 2001 From: solegalli Date: Fri, 7 Nov 2025 17:26:43 -0500 Subject: [PATCH 10/10] update supported versions of sklearn and numpy --- .github/workflows/test_package.yml | 4 ---- requirements.txt | 4 ++-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/test_package.yml b/.github/workflows/test_package.yml index 0053d2a..0486d0e 100644 --- a/.github/workflows/test_package.yml +++ b/.github/workflows/test_package.yml @@ -19,8 +19,6 @@ jobs: - python-version: "3.13" # Python 3.11 with different scikit-learn versions - - python-version: "3.11" - sklearn-version: "1.4.0" - python-version: "3.11" sklearn-version: "1.5.2" - python-version: "3.11" @@ -29,8 +27,6 @@ jobs: sklearn-version: "1.7.0" # Python 3.11 with different NumPy versions - - python-version: "3.11" - numpy-version: "1.18.2" - python-version: "3.11" numpy-version: "1.26.4" - python-version: "3.11" diff --git a/requirements.txt b/requirements.txt index cc0cf5b..e22d5f1 100644 --- a/requirements.txt +++ b/requirements.txt @@ -1,3 +1,3 @@ -numpy>=1.18.2 +numpy>=1.26.4 pandas>=2.2.0 -scikit-learn>=1.4.0 \ No newline at end of file +scikit-learn>=1.5.2 \ No newline at end of file