Skip to content

Conversation

@jjshoots
Copy link
Contributor

Description

Adds pre-commit to add some level of standardization across the code.

Pyright checking is not done yet, will probably do that another time as it has quite a bit of errors there.

Checklist

  • Check that the base branch is set to develop and not main.
  • Ensure that the documentation will be consistent with the code upon merging.
  • Add a line or a few lines that check the new features added.
  • Ensure that unit tests pass.
    If you don't have a premium proxy, some of the tests will be skipped.
    The tests that are run should pass without raising
    MaxTriesExceededException or other exceptions.

@arunkannawadi arunkannawadi force-pushed the develop branch 3 times, most recently from 629fdd5 to 768bc48 Compare October 19, 2022 18:46
@arunkannawadi arunkannawadi added this to the v1.8 milestone Oct 19, 2022
@arunkannawadi arunkannawadi force-pushed the develop branch 6 times, most recently from 04275ba to 4cabc51 Compare October 20, 2022 19:42
Copy link
Collaborator

@arunkannawadi arunkannawadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been wanting to set this up for a while, but kept postponing it. I will have to break this up into more commits, and all the changes introduced by the formatters should be in one single, bit commit so I can set that to be ignored when going through history. I'll merge this after some of the existing branches are merged so the formatting applies to everything at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants