Skip to content

Commit 84f9e26

Browse files
Merge pull request #480 from scholarly-python-package/develop
(Pre-)Release v1.7.10 to enable conda build
2 parents 80aad41 + 434b25c commit 84f9e26

File tree

2 files changed

+20
-9
lines changed

2 files changed

+20
-9
lines changed

scholarly/_proxy_generator.py

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
from selenium.common.exceptions import WebDriverException, UnexpectedAlertPresentException
1515
from selenium.webdriver.firefox.options import Options as FirefoxOptions
1616
from urllib.parse import urlparse
17-
from fake_useragent import UserAgent
1817
from contextlib import contextmanager
1918
from deprecated import deprecated
2019
try:
@@ -24,6 +23,13 @@
2423
except ImportError:
2524
stem = None
2625

26+
try:
27+
from fake_useragent import UserAgent
28+
FAKE_USERAGENT = True
29+
except Exception:
30+
FAKE_USERAGENT = False
31+
DEFAULT_USER_AGENT = 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.149 Safari/537.36'
32+
2733
from .data_types import ProxyMode
2834

2935

@@ -454,13 +460,18 @@ def _new_session(self, **kwargs):
454460
# self._session = httpx.Client()
455461
self.got_403 = False
456462

457-
# Suppress the misleading traceback from UserAgent()
458-
with self._suppress_logger('fake_useragent'):
459-
_HEADERS = {
460-
'accept-language': 'en-US,en',
461-
'accept': 'text/html,application/xhtml+xml,application/xml',
462-
'User-Agent': UserAgent().random,
463-
}
463+
if FAKE_USERAGENT:
464+
# Suppress the misleading traceback from UserAgent()
465+
with self._suppress_logger('fake_useragent'):
466+
user_agent = UserAgent().random
467+
else:
468+
user_agent = DEFAULT_USER_AGENT
469+
470+
_HEADERS = {
471+
'accept-language': 'en-US,en',
472+
'accept': 'text/html,application/xhtml+xml,application/xml',
473+
'User-Agent': user_agent,
474+
}
464475
# self._session.headers.update(_HEADERS)
465476
init_kwargs.update(headers=_HEADERS)
466477

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
setuptools.setup(
77
name='scholarly',
8-
version='1.7.9',
8+
version='1.7.10-alpha',
99
author='Steven A. Cholewiak, Panos Ipeirotis, Victor Silva, Arun Kannawadi',
1010
author_email='steven@cholewiak.com, panos@stern.nyu.edu, vsilva@ualberta.ca, arunkannawadi@astro.princeton.edu',
1111
description='Simple access to Google Scholar authors and citations',

0 commit comments

Comments
 (0)