Skip to content

Commit 5561061

Browse files
committed
Update the proxy keys in _get_webdriver routines
to reflect the changes that happened when we moved to httpx. Fixes an issue reported in #498.
1 parent 2a5804a commit 5561061

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

scholarly/_proxy_generator.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -365,8 +365,8 @@ def _get_webdriver(self):
365365
def _get_chrome_webdriver(self):
366366
if self._proxy_works:
367367
webdriver.DesiredCapabilities.CHROME['proxy'] = {
368-
"httpProxy": self._proxies['http'],
369-
"sslProxy": self._proxies['https'],
368+
"httpProxy": self._proxies['http://'],
369+
"sslProxy": self._proxies['https://'],
370370
"proxyType": "MANUAL"
371371
}
372372

@@ -381,8 +381,8 @@ def _get_firefox_webdriver(self):
381381
if self._proxy_works:
382382
# Redirect webdriver through proxy
383383
webdriver.DesiredCapabilities.FIREFOX['proxy'] = {
384-
"httpProxy": self._proxies['http'],
385-
"sslProxy": self._proxies['https'],
384+
"httpProxy": self._proxies['http://'],
385+
"sslProxy": self._proxies['https://'],
386386
"proxyType": "MANUAL",
387387
}
388388

0 commit comments

Comments
 (0)