Skip to content

Commit 8fc2960

Browse files
Use constants for height values for charts for better consistency.
1 parent f00f5f2 commit 8fc2960

File tree

4 files changed

+12
-6
lines changed

4 files changed

+12
-6
lines changed

ui/src/components/DashboardChartSystemLoad.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import {
1919
getNodesSystemLoadQuery,
2020
} from '../services/platformlibrary/metrics';
2121
import NonSymmetricalQuantileChart from './NonSymmetricalQuantileChart';
22+
import { HEIGHT_DEFAULT_CHART } from '../constants';
2223

2324
const DashboardChartSystemLoad = () => {
2425
const { isShowQuantileChart } = useShowQuantileChart();
@@ -67,7 +68,7 @@ const DashboardChartSystemLoadWithoutQuantiles = () => {
6768
return (
6869
<LineTimeSerieChart
6970
series={series}
70-
height={110}
71+
height={HEIGHT_DEFAULT_CHART}
7172
interval={interval}
7273
duration={duration}
7374
title="System Load"

ui/src/components/DashboardChartThroughput.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,11 @@ import {
2222
} from '../services/platformlibrary/metrics';
2323
import { getMultipleSymmetricalSeries } from '../services/graphUtils';
2424
import SymmetricalQuantileChart from './SymmetricalQuantileChart';
25-
import { UNIT_RANGE_BS, YAXIS_TITLE_READ_WRITE } from '../constants';
25+
import {
26+
HEIGHT_SYMMETRICAL_CHART,
27+
UNIT_RANGE_BS,
28+
YAXIS_TITLE_READ_WRITE,
29+
} from '../constants';
2630

2731
const DashboardChartThroughput = () => {
2832
const { isShowQuantileChart } = useShowQuantileChart();
@@ -105,7 +109,7 @@ const DashboardChartThroughputWithoutQuantile = () => {
105109
above: series.above,
106110
below: series.below,
107111
}}
108-
height={150}
112+
height={HEIGHT_SYMMETRICAL_CHART}
109113
unitRange={UNIT_RANGE_BS}
110114
interval={interval}
111115
duration={duration}

ui/src/components/NonSymmetricalQuantileChart.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {
77
import { useCallback, useMemo } from 'react';
88
import { UseQueryOptions } from 'react-query';
99
import { useSelector } from 'react-redux';
10-
import { PORT_NODE_EXPORTER } from '../constants';
10+
import { HEIGHT_DEFAULT_CHART, PORT_NODE_EXPORTER } from '../constants';
1111
import { useChartSeries, useNodeAddressesSelector, useNodes } from '../hooks';
1212
import {
1313
convertPrometheusResultToSerie,
@@ -169,7 +169,7 @@ const NonSymmetricalQuantileChart = ({
169169
<ChartLegendWrapper colorSet={colorSet}>
170170
<LineTimeSerieChart
171171
series={seriesQuantile}
172-
height={110}
172+
height={HEIGHT_DEFAULT_CHART}
173173
title={title}
174174
helpText={helpText}
175175
startingTimeStamp={startingTimeStampQuantile}

ui/src/components/VolumeCharts.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import {
77
} from '@scality/core-ui/dist/next';
88
import { useCallback } from 'react';
99
import {
10+
HEIGHT_DEFAULT_CHART,
1011
UNIT_RANGE_BS,
1112
UNIT_RANGE_SECONDS,
1213
YAXIS_TITLE_READ_WRITE,
@@ -224,7 +225,7 @@ export const VolumeUsageChart = ({
224225
<Stack direction="vertical" gap="r1">
225226
<LineTimeSerieChart
226227
series={series}
227-
height={160}
228+
height={HEIGHT_DEFAULT_CHART}
228229
interval={interval}
229230
duration={duration}
230231
title="Usage"

0 commit comments

Comments
 (0)