Skip to content

Commit 4b59ba5

Browse files
fix scrolling for graph tabs
1 parent bafe55a commit 4b59ba5

File tree

2 files changed

+20
-22
lines changed

2 files changed

+20
-22
lines changed

ui/src/components/VolumeMetricsTab.tsx

Lines changed: 19 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -39,29 +39,26 @@ const MetricsTab = (props) => {
3939
<>
4040
{volumeCondition === VOLUME_CONDITION_LINK ? (
4141
<ChartLegendWrapper colorSet={createColorSet}>
42+
<MetricsActionContainer>
43+
{config.api?.url_grafana && volumeNamespace && volumePVCName && (
44+
<a
45+
href={`${config.api.url_grafana}/d/${GRAFANA_DASHBOARDS.volumes}?var-namespace=${volumeNamespace}&var-volume=${volumePVCName}`}
46+
target="_blank"
47+
rel="noopener noreferrer"
48+
data-cy="advanced_metrics_volume_detailed"
49+
>
50+
<Button
51+
label={intl.formatMessage({
52+
id: 'advanced_metrics',
53+
})}
54+
variant={'secondary'}
55+
icon={<Icon name="External-link" />}
56+
/>
57+
</a>
58+
)}
59+
{volumeCondition === VOLUME_CONDITION_LINK && <TimespanSelector />}
60+
</MetricsActionContainer>
4261
<ChartContainer>
43-
<MetricsActionContainer>
44-
{config.api?.url_grafana && volumeNamespace && volumePVCName && (
45-
<a
46-
href={`${config.api.url_grafana}/d/${GRAFANA_DASHBOARDS.volumes}?var-namespace=${volumeNamespace}&var-volume=${volumePVCName}`}
47-
target="_blank"
48-
rel="noopener noreferrer"
49-
data-cy="advanced_metrics_volume_detailed"
50-
>
51-
<Button
52-
label={intl.formatMessage({
53-
id: 'advanced_metrics',
54-
})}
55-
variant={'secondary'}
56-
icon={<Icon name="External-link" />}
57-
/>
58-
</a>
59-
)}
60-
{volumeCondition === VOLUME_CONDITION_LINK && (
61-
<TimespanSelector />
62-
)}
63-
</MetricsActionContainer>
64-
6562
<GraphGrid id="graph_container">
6663
<VolumeUsageChart
6764
pvcName={volumePVCName}

ui/src/containers/NodePageMetricsTab.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ export const ChartContainer = styled.div`
5151
/* 100% - padding - action container height */
5252
height: calc(100% - 3rem);
5353
padding-left: ${spacing.r12};
54+
overflow: hidden auto;
5455
`;
5556
export const GraphGrid = styled.div`
5657
display: grid;

0 commit comments

Comments
 (0)