putBucketReplication additional tests migration

Author: benzekrimaha

tests/functional/aws-node-sdk/test/bucket/putBucketReplication.js

@@ -3,6 +3,8 @@ const { errors } = require('arsenal');
 const { S3Client,
     CreateBucketCommand,
     DeleteBucketCommand,
+    DeleteBucketCorsCommand,
+    PutBucketCorsCommand,
     PutBucketReplicationCommand,
     PutBucketVersioningCommand } = require('@aws-sdk/client-s3');
 const { series } = require('async');
@@ -408,41 +410,38 @@ describe('aws-node-sdk test putBucketReplication CORS', () => {
     let s3;
     const bucket = 'source-bucket-cors';
 
-    beforeEach(done => {
+    beforeEach(async () => {
         const config = getConfig('default', { signatureVersion: 'v4' });
-        s3 = new S3(config);
-        series([
-            next => s3.createBucket({ Bucket: bucket }, next),
-            next => s3.putBucketVersioning({
-                Bucket: bucket,
-                VersioningConfiguration: { Status: 'Enabled' },
-            }, next),
-            next => s3.putBucketCors({
-                Bucket: bucket,
-                CORSConfiguration: {
-                    CORSRules: [{
-                        AllowedOrigins: ['*'],
-                        AllowedMethods: ['PUT'],
-                        AllowedHeaders: ['*'],
-                    }],
-                },
-            }, next),
-        ], done);
+        s3 = new S3Client(config);
+        await s3.send(new CreateBucketCommand({ Bucket: bucket }));
+        await s3.send(new PutBucketVersioningCommand({
+            Bucket: bucket,
+            VersioningConfiguration: { Status: 'Enabled' },
+        }));
+        await s3.send(new PutBucketCorsCommand({
+            Bucket: bucket,
+            CORSConfiguration: {
+                CORSRules: [{
+                    AllowedOrigins: ['*'],
+                    AllowedMethods: ['PUT'],
+                    AllowedHeaders: ['*'],
+                }],
+            },
+        }));
     });
 
-    afterEach(done => {
-        series([
-            next => s3.deleteBucketCors({ Bucket: bucket }, err => {
-                if (err && err.code !== 'NoSuchCORSConfiguration') {
-                    return next(err);
-                }
-                return next();
-            }),
-            next => s3.deleteBucket({ Bucket: bucket }, next),
-        ], done);
+    afterEach(async () => {
+        try {
+            await s3.send(new DeleteBucketCorsCommand({ Bucket: bucket }));
+        } catch (err) {
+            if (err.name !== 'NoSuchCORSConfiguration') {
+                throw err;
+            }
+        }
+        await s3.send(new DeleteBucketCommand({ Bucket: bucket }));
     });
 
-    it('should return malformed XML error in XML is invalid', done => {
+    it('should return malformed XML error in XML is invalid', async () => {
         const replicationParams = {
             Bucket: bucket,
             ReplicationConfiguration: {
@@ -451,13 +450,26 @@ describe('aws-node-sdk test putBucketReplication CORS', () => {
                 Rules: [],
             },
         };
-        const request = s3.putBucketReplication(replicationParams);
-        request.on('build', () => {
-            request.httpRequest.headers.Origin = 'http://example.com';
-        });
-        request.send(err => {
+        const command = new PutBucketReplicationCommand(replicationParams);
+        command.middlewareStack.add(
+            (next) => async args => {
+                if (args.request && args.request.headers) {
+                    args.request.headers.Origin = 'http://example.com';
+                }
+                return next(args);
+            },
+            {
+                name: 'injectOriginHeader',
+                step: 'build',
+                priority: 'high',
+            }
+        );
+
+        try {
+            await s3.send(command);
+            assert.fail('Expected MalformedXML error');
+        } catch (err) {
             assertError(err, 'MalformedXML');
-            done();
-        });
+        }
     });
 });