test(baremetal): register cassettes

Author: Laure-di

internal/services/baremetal/server.go

@@ -2,13 +2,8 @@ package baremetal
 
 import (
 	"context"
-	"encoding/base64"
 	"encoding/json"
-	"errors"
 	"fmt"
-	"os"
-	"path/filepath"
-	"strings"
 
 	"github.com/hashicorp/go-cty/cty"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
@@ -380,12 +375,8 @@ func ResourceServerCreate(ctx context.Context, d *schema.ResourceData, m any) di
 	}
 
 	if cloudInit, ok := d.GetOk("cloud_init"); ok {
-		userData, err := LoadUserDataBase64(cloudInit)
-		if err != nil {
-			return diag.FromErr(err)
-		}
-
-		req.UserData = &userData
+		cloudInitStr := []byte(cloudInit.(string))
+		req.UserData = &cloudInitStr
 	}
 
 	partitioningSchema := baremetal.Schema{}
@@ -478,54 +469,6 @@ func ResourceServerCreate(ctx context.Context, d *schema.ResourceData, m any) di
 	return ResourceServerRead(ctx, d, m)
 }
 
-func LoadUserDataBase64(cloudInit any) ([]byte, error) {
-	value := cloudInit.(string)
-
-	var content []byte
-
-	// If value refers to an existing file, read it. Otherwise treat value as the content.
-	if fi, err := os.Stat(value); err == nil {
-		// Only allow regular files
-		if !fi.Mode().IsRegular() {
-			return nil, fmt.Errorf("cloud_init path is not a regular file: %s", value)
-		}
-
-		// Resolve absolute path and ensure it is within the current working directory
-		absPath, err := filepath.Abs(value)
-		if err != nil {
-			return nil, err
-		}
-
-		cwd, err := os.Getwd()
-		if err != nil {
-			return nil, err
-		}
-
-		absPath = filepath.Clean(absPath)
-		cwd = filepath.Clean(cwd)
-
-		if absPath != cwd && !strings.HasPrefix(absPath, cwd+string(os.PathSeparator)) {
-			return nil, fmt.Errorf("reading cloud_init from outside working directory is disallowed: %s", value)
-		}
-
-		data, err := os.ReadFile(absPath)
-		if err != nil {
-			return nil, err
-		}
-
-		content = data
-	} else if errors.Is(err, os.ErrNotExist) {
-		content = []byte(value)
-	} else {
-		return nil, err
-	}
-
-	encoded := base64.StdEncoding.EncodeToString(content)
-	userData := []byte(encoded)
-
-	return userData, nil
-}
-
 func ResourceServerRead(ctx context.Context, d *schema.ResourceData, m any) diag.Diagnostics {
 	api, zonedID, err := NewAPIWithZoneAndID(m, d.Id())
 	if err != nil {
@@ -583,7 +526,11 @@ func ResourceServerRead(ctx context.Context, d *schema.ResourceData, m any) diag
 	_ = d.Set("ipv4", flattenIPv4s(server.IPs))
 	_ = d.Set("ipv6", flattenIPv6s(server.IPs))
 	_ = d.Set("protected", server.Protected)
-	_ = d.Set("cloud_init", server.UserData)
+	var cloudInit string
+	if server.UserData != nil {
+		cloudInit = string(*server.UserData)
+	}
+	_ = d.Set("cloud_init", cloudInit)
 
 	if server.Install != nil {
 		_ = d.Set("os", zonal.NewIDString(server.Zone, os.ID))
@@ -767,14 +714,9 @@ func ResourceServerUpdate(ctx context.Context, d *schema.ResourceData, m any) di
 	hasChanged := false
 
 	if d.HasChange("cloud_init") {
-		cloudInit := d.Get("cloud_init").(string)
-
-		userData, err := LoadUserDataBase64(cloudInit)
-		if err != nil {
-			return diag.FromErr(err)
-		}
-
-		req.UserData = &userData
+		cloudInit, _ := d.Get("cloud_init").(string)
+		cloudInitStr := []byte(cloudInit)
+		req.UserData = &cloudInitStr
 		hasChanged = true
 	}
 

internal/services/baremetal/server_test.go

@@ -116,6 +116,179 @@ func TestAccServer_Basic(t *testing.T) {
 	})
 }
 
+func TestAccServer_CloudInit(t *testing.T) {
+	tt := acctest.NewTestTools(t)
+	defer tt.Cleanup()
+
+	if !IsOfferAvailable(OfferName, scw.Zone(Zone), tt) {
+		t.Skip("Offer is out of stock")
+	}
+
+	SSHKeyName := "TestAccServer_CloudInit"
+	name := "TestAccServer_CloudInit"
+
+	resource.ParallelTest(t, resource.TestCase{
+		ProtoV6ProviderFactories: tt.ProviderFactories,
+		CheckDestroy:             baremetalchecks.CheckServerDestroy(tt),
+
+		Steps: []resource.TestStep{
+			{
+				Config: fmt.Sprintf(`
+					variable "cloud_init" {
+					  type = string
+					  default = <<EOF
+#cloud-config
+apt_update: true
+apt_upgrade: true
+					EOF
+					}
+
+					data "scaleway_baremetal_os" "my_os" {
+					zone    = "%s"
+					name    = "Ubuntu"
+					version = "22.04 LTS (Jammy Jellyfish)"
+					}
+
+					resource "scaleway_iam_ssh_key" "main" {
+					name       = "%s"
+					public_key = "%s"
+					}
+
+					resource "scaleway_baremetal_server" "base" {
+					name        = "%s"
+					zone        = "%s"
+					description = "test a description"
+					offer       = "%s"
+					os          = data.scaleway_baremetal_os.my_os.os_id
+
+					cloud_init = var.cloud_init
+
+					tags        = ["terraform-test", "scaleway_baremetal_server", "cloudinit"]
+					ssh_key_ids = [scaleway_iam_ssh_key.main.id]
+					}
+					`, Zone, SSHKeyName, SSHKeyBaremetal, name, Zone, OfferName),
+
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckBaremetalServerExists(tt, "scaleway_baremetal_server.base"),
+					resource.TestCheckResourceAttr("scaleway_baremetal_server.base", "name", name),
+					resource.TestCheckResourceAttr("scaleway_baremetal_server.base", "offer_name", OfferName),
+					resource.TestCheckResourceAttr("scaleway_baremetal_server.base", "cloud_init", "#cloud-config\napt_update: true\napt_upgrade: true\n"),
+				),
+			},
+
+			{
+				// Update cloud-init + reinstall
+				Config: fmt.Sprintf(`
+					variable "cloud_init" {
+					  type = string
+					  default = <<EOF
+#cloud-config
+apt_update: true
+apt_upgrade: true
+
+packages:
+ - curl
+EOF
+					}
+
+					data "scaleway_baremetal_os" "my_os" {
+					zone    = "%s"
+					name    = "Ubuntu"
+					version = "22.04 LTS (Jammy Jellyfish)"
+					}
+
+					resource "scaleway_iam_ssh_key" "main" {
+					name       = "%s"
+					public_key = "%s"
+					}
+
+					resource "scaleway_baremetal_server" "base" {
+					name        = "%s"
+					zone        = "%s"
+					description = "test a description"
+					offer       = "%s"
+					os          = data.scaleway_baremetal_os.my_os.os_id
+
+					cloud_init = var.cloud_init
+
+					tags        = ["terraform-test", "scaleway_baremetal_server", "cloudinit", "edited"]
+					ssh_key_ids = [scaleway_iam_ssh_key.main.id]
+					}
+					`, Zone, SSHKeyName, SSHKeyBaremetal, name, Zone, OfferName),
+
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckBaremetalServerExists(tt, "scaleway_baremetal_server.base"),
+					resource.TestCheckResourceAttr(
+						"scaleway_baremetal_server.base",
+						"cloud_init",
+						"#cloud-config\napt_update: true\napt_upgrade: true\n\npackages:\n - curl\n",
+					),
+					resource.TestCheckResourceAttr("scaleway_baremetal_server.base", "tags.#", "4"),
+				),
+			},
+		},
+	})
+}
+
+func TestAccServer_CloudInitNotCompatibleOffer(t *testing.T) {
+	tt := acctest.NewTestTools(t)
+	defer tt.Cleanup()
+
+	if !IsOfferAvailable(OfferName, scw.Zone(Zone), tt) {
+		t.Skip("Offer is out of stock")
+	}
+
+	SSHKeyName := "TestAccServer_CloudInitIncompatibleOffer"
+	name := "TestAccServer_CloudInitIncompatibleOffer"
+	OfferNameNotCompatible := "EM-L110X-SATA"
+
+	resource.ParallelTest(t, resource.TestCase{
+		ProtoV6ProviderFactories: tt.ProviderFactories,
+		CheckDestroy:             baremetalchecks.CheckServerDestroy(tt),
+
+		Steps: []resource.TestStep{
+			{
+				Config: fmt.Sprintf(`
+					variable "cloud_init" {
+					  type = string
+					  default = <<EOF
+#cloud-config
+apt_update: true
+apt_upgrade: true
+					EOF
+					}
+
+					data "scaleway_baremetal_os" "my_os" {
+					zone    = "%s"
+					name    = "Ubuntu"
+					version = "22.04 LTS (Jammy Jellyfish)"
+					}
+
+					resource "scaleway_iam_ssh_key" "main" {
+					name       = "%s"
+					public_key = "%s"
+					}
+
+					resource "scaleway_baremetal_server" "base" {
+					name        = "%s"
+					zone        = "%s"
+					description = "test a description"
+					offer       = "%s"
+					os          = data.scaleway_baremetal_os.my_os.os_id
+
+					cloud_init = var.cloud_init
+
+					tags        = ["terraform-test", "scaleway_baremetal_server", "cloudinit"]
+					ssh_key_ids = [scaleway_iam_ssh_key.main.id]
+					}
+					`, Zone, SSHKeyName, SSHKeyBaremetal, name, Zone, OfferNameNotCompatible),
+
+				ExpectError: regexp.MustCompile("Service Unavailable: cloud-init is not supported on this offer"),
+			},
+		},
+	})
+}
+
 func TestAccServer_RequiredInstallConfig(t *testing.T) {
 	tt := acctest.NewTestTools(t)
 	defer tt.Cleanup()