Split make prepare-release

The Makefile rule `make prepare-release` was used to build:

* scaleway-cli dist files for several architectures
* scaleway-cli debian packages
* scaleway-cli Docker image

By splitting the Makefile rule into the three rules, it is possible to
call make prepare-release-dist from a container (so no need to have go
installed on the host) and the two other rules,
prepare-release-debian-packages and prepare-release-docker-image, from a
Docker host (since they spawn a Docker container).

Author: Julien Castets

MAINTAINERS.md

@@ -24,15 +24,15 @@ For the sake of the example, we assume you want to release the version `42.8`.
 
 * [Draft a new release](https://github.com/scaleway/scaleway-cli/releases) on
   Github.
-* Build release files: `make prepare-release`.
-* Upload the generated files in *dist/42.8/* to github.
-* Publish the release.
+* Build cross-compiled files: `make prepare-release-dist`.
+* Build debian packages: `make prepare-release-debian-packages VERSION=42.8`.
+  **The VERSION should not include the leading "v"**.
+* Upload the generated files in `dist/latest` and publish the release.
 
 ### Docker image
 
-The image *scaleway/cli* has been created by `make prepare-release` called
-during the previous step.
-
+* Call `make prepare-release-docker-image VERSION=42.8`. **The VERSION should
+  not include the leading "v"**.
 * Push the local Docker image to the Docker hub: `docker push scaleway/cli`.
 
 ### Homebrew (OSX) package

Makefile

@@ -70,7 +70,7 @@ fmt: $(FMT_LIST)
 
 $(BUILD_LIST): %_build: %_fmt
 	@go tool vet --all=true $(shell echo $(SOURCES) | tr " " "\n" | grep -v test.go)
-	$(GOBUILD) -i -ldflags $(LDFLAGS) -o $(NAME) ./cmd/$(NAME)
+	$(GOBUILD) -ldflags $(LDFLAGS) -o $(NAME) ./cmd/$(NAME)
 
 $(CLEAN_LIST): %_clean:
 	$(GOCLEAN) $(subst $(GODIR),./,$*)
@@ -84,7 +84,7 @@ $(TEST_LIST): %_test:
 $(FMT_LIST): %_fmt:
 	@$(GOFMT) $(SOURCES)
 
-prepare-release: build
+prepare-release-dist: build
 	### Prepare dist/ directory ###
 	$(eval VERSION := $(shell ./scw version | sed -n 's/Client version: v\(.*\)/\1/p'))
 	rm -rf dist/$(VERSION)
@@ -111,21 +111,21 @@ prepare-release: build
 	GOOS=windows GOARCH=386   go build -o dist/latest/scw-windows-i386.exe  github.com/scaleway/scaleway-cli/cmd/scw
 	GOOS=windows GOARCH=amd64 go build -o dist/latest/scw-windows-amd64.exe github.com/scaleway/scaleway-cli/cmd/scw
 
+prepare-release-docker-image: dist/latest/scw-linux-i386
+	@echo ${VERSION} | grep -qv 'v' || ( echo "ERROR: VERSION not set or contains a leading 'v'" >&2 && exit 1 )
 	### Prepare scaleway-cli Docker image ###
 	docker run --rm golang tar -cf - /etc/ssl > dist/ssl.tar
 	docker build -t scaleway/cli dist
 	docker run scaleway/cli version
-	docker tag scaleway/cli:latest scaleway/cli:$(TAG)
+	docker tag scaleway/cli:latest scaleway/cli:v$(VERSION)
 
+prepare-release-debian-packages: dist/latest/scw-linux-amd64 dist/latest/scw-linux-i386 dist/latest/scw-linux-arm
+	@echo ${VERSION} | grep -qv 'v' || ( echo "ERROR: VERSION not set or contains a leading 'v'" >&2 && exit 1 )
 	### Build debian packages ###
 	docker run -v $(PWD)/dist/latest/scw-linux-amd64:/input/usr/bin/scw $(FPM_DOCKER) $(FPM_ARGS) --version $(VERSION) -t deb -a x86_64 ./
 	docker run -v $(PWD)/dist/latest/scw-linux-i386:/input/usr/bin/scw  $(FPM_DOCKER) $(FPM_ARGS) --version $(VERSION) -t deb -a i386 ./
 	docker run -v $(PWD)/dist/latest/scw-linux-arm:/input/usr/bin/scw   $(FPM_DOCKER) $(FPM_ARGS) --version $(VERSION) -t deb -a arm ./
 
-	### DONE ###
-	@echo "Release files have been created into dist/latest. See MAINTAINERS.md."
-	@echo "The scaleway-cli Docker image has been created. See MAINTAINERS.md."
-
 
 .PHONY: golint
 golint: