Add optional screenshot argument to FrameTimingSequence (facebook#54743)

Summary:
Pull Request resolved: facebook#54743

Instead of creating another buffer, optionally include screenshots if they are enabled in `FrameTimingSequence`.

Changelog: [Internal]

Reviewed By: hoxyq

Differential Revision: D87936871

fbshipit-source-id: c35ef7776f6f51281213664f98e13db0a2bbab42

Author: sbuggay

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/inspector/FrameTimingSequence.kt

@@ -13,4 +13,5 @@ internal data class FrameTimingSequence(
     val beginDrawingTimestamp: Long,
     val commitTimestamp: Long,
     val endDrawingTimestamp: Long,
+    val screenshot: String? = null,
 )

packages/react-native/ReactAndroid/src/main/jni/react/runtime/jni/JReactHostInspectorTarget.cpp

@@ -300,6 +300,7 @@ void JReactHostInspectorTarget::recordFrameTimings(
       frameTimingSequence->getBeginDrawingTimestamp(),
       frameTimingSequence->getCommitTimestamp(),
       frameTimingSequence->getEndDrawingTimestamp(),
+      frameTimingSequence->getScreenshot(),
   });
 }
 

packages/react-native/ReactAndroid/src/main/jni/react/runtime/jni/JReactHostInspectorTarget.h

@@ -67,6 +67,17 @@ struct JFrameTimingSequence : public jni::JavaClass<JFrameTimingSequence> {
     return HighResTimeStamp::fromChronoSteadyClockTimePoint(
         std::chrono::steady_clock::time_point(std::chrono::nanoseconds(getFieldValue(field))));
   }
+
+  std::optional<std::string> getScreenshot() const
+  {
+    auto field = javaClassStatic()->getField<jstring>("screenshot");
+    auto javaScreenshot = getFieldValue(field);
+    if (javaScreenshot) {
+      auto jstring = jni::static_ref_cast<jni::JString>(javaScreenshot);
+      return jstring->toStdString();
+    }
+    return std::nullopt;
+  }
 };
 
 struct JReactHostImpl : public jni::JavaClass<JReactHostImpl> {

packages/react-native/ReactCommon/jsinspector-modern/tracing/FrameTimingSequence.h

@@ -24,12 +24,14 @@ struct FrameTimingSequence {
       ThreadId threadId,
       HighResTimeStamp beginDrawingTimestamp,
       HighResTimeStamp commitTimestamp,
-      HighResTimeStamp endDrawingTimestamp)
+      HighResTimeStamp endDrawingTimestamp,
+      std::optional<std::string> screenshot = std::nullopt)
       : id(id),
         threadId(threadId),
         beginDrawingTimestamp(beginDrawingTimestamp),
         commitTimestamp(commitTimestamp),
-        endDrawingTimestamp(endDrawingTimestamp)
+        endDrawingTimestamp(endDrawingTimestamp),
+        screenshot(std::move(screenshot))
   {
   }
 
@@ -46,6 +48,11 @@ struct FrameTimingSequence {
   HighResTimeStamp beginDrawingTimestamp;
   HighResTimeStamp commitTimestamp;
   HighResTimeStamp endDrawingTimestamp;
+
+  /**
+   * Optional screenshot data (base64 encoded) captured during the frame.
+   */
+  std::optional<std::string> screenshot;
 };
 
 } // namespace facebook::react::jsinspector_modern::tracing