Fix retry implementation; upgrade settings (#71)

Author: sbabcoc

build.gradle

@@ -195,7 +195,7 @@ repositories {
 dependencies {
   constraints {
     api 'com.nordstrom.tools:java-utils:3.4.1'
-    api 'com.nordstrom.tools:settings:3.0.7'
+    api 'com.nordstrom.tools:settings:3.0.8'
   }
   api 'com.nordstrom.tools:java-utils'
   api 'com.nordstrom.tools:settings'

gradle.properties

@@ -1,2 +1,2 @@
 profile=java11
-version=3.0.8-SNAPSHOT
+version=5.2.0-SNAPSHOT

src/main/java/com/nordstrom/automation/testng/RetryManager.java

@@ -78,7 +78,7 @@ public class RetryManager implements IRetryAnalyzer {
 
     private final TestNGConfig config;
     private final Map<InvocationRecord, Integer> invocations;
-    private final ServiceLoader<IRetryAnalyzer> retryAnalyzerLoader;
+    private final ServiceLoader<TestNGRetryAnalyzer> retryAnalyzerLoader;
     private final Logger logger = LoggerFactory.getLogger(getClass());
 
     /**
@@ -87,7 +87,7 @@ public class RetryManager implements IRetryAnalyzer {
     public RetryManager() {
         config = TestNGConfig.getConfig();
         invocations = new ConcurrentHashMap<>();
-        retryAnalyzerLoader = ServiceLoader.load(IRetryAnalyzer.class);
+        retryAnalyzerLoader = ServiceLoader.load(TestNGRetryAnalyzer.class);
     }
 
     /**
@@ -126,7 +126,7 @@ public boolean retry(final ITestResult result) {
      */
     protected boolean isRetriable(final ITestResult result) {
         synchronized(retryAnalyzerLoader) {
-            for (IRetryAnalyzer analyzer : retryAnalyzerLoader) {
+            for (TestNGRetryAnalyzer analyzer : retryAnalyzerLoader) {
                 if (analyzer.retry(result)) {
                     return true;
                 }

src/main/java/com/nordstrom/automation/testng/TestNGRetryAnalyzer.java

@@ -0,0 +1,18 @@
+package com.nordstrom.automation.testng;
+
+import org.testng.ITestResult;
+
+/**
+ * <b>TestNG Foundation</b> retry analyzers implement this interface. 
+ */
+public interface TestNGRetryAnalyzer {
+
+    /**
+     * Determine if the specified failed test should be retried.
+     *  
+     * @param result failed result to be evaluated
+     * @return {@code true} if test should be retried; otherwise {@code false}
+     */
+    boolean retry(final ITestResult result);
+    
+}