Add Mac2 page class/test; final/(un)boxing cleanup (#239)

Co-authored-by: Scott Babcock <scbabco@rei.com>

Author: sbabcoc

src/main/java/com/nordstrom/automation/selenium/AbstractSeleniumConfig.java

@@ -572,7 +572,7 @@ public String resolveString(String propertyName) {
                     Path path = Paths.get(valuePath);
                     URL url = path.toUri().toURL();
                     propertyValue = Resources.toString(url, Charsets.UTF_8);
-                } catch (IOException e) {
+                } catch (IOException eaten) {
                     // nothing to do here
                 }
             }
@@ -665,7 +665,7 @@ public URI getTargetUri() {
 
             try {
                 targetUri = builder.build().normalize();
-            } catch (URISyntaxException eaten) { //NOSONAR
+            } catch (URISyntaxException eaten) {
                 LOGGER.error("Specified target URI '{}' could not be parsed: {}", builder, eaten.getMessage());
             }
         }
@@ -857,9 +857,9 @@ private static String getConfigPath(final String path) {
                 URI uri = getConfigUri(path, url);
                 File file = new File(uri);
                 return file.getAbsolutePath();
-            } catch (URISyntaxException eaten) { //NOSONAR
+            } catch (URISyntaxException eaten) {
                 LOGGER.warn("Invalid URL returned by file locator: {}", eaten.getMessage());
-            } catch (IOException eaten) { //NOSONAR
+            } catch (IOException eaten) {
                 LOGGER.warn("Failed to construct file system or extract configuration file: {}", eaten.getMessage());
             }
         }
@@ -880,7 +880,7 @@ private static URI getConfigUri(final String path, final URL url) throws URISynt
         if ("jar".equals(uri.getScheme())) {
             try {
                 FileSystems.newFileSystem(uri, Collections.<String, Object>emptyMap());
-            } catch (FileSystemAlreadyExistsException eaten) { //NOSONAR
+            } catch (FileSystemAlreadyExistsException eaten) {
                 LOGGER.warn("Specified file system already exists: {}", eaten.getMessage());
             } 
 

src/main/java/com/nordstrom/automation/selenium/core/DriverManager.java

@@ -184,7 +184,7 @@ public static void setDriverTimeouts(final WebDriver driver, final SeleniumConfi
 
         try {
             timeouts.pageLoadTimeout(WaitType.PAGE_LOAD.getInterval(config), TimeUnit.SECONDS);
-        } catch (WebDriverException e) {
+        } catch (WebDriverException eaten) {
             // unsupported feature: nothing to do here
         }
     }
@@ -242,13 +242,13 @@ public static Optional<WebDriver> closeDriver(final Object obj) {
 
             try {
                 ((JavascriptExecutor) driver).executeScript("return window.stop");
-            } catch (WebDriverException | UnsupportedOperationException e) { //NOSONAR
+            } catch (WebDriverException | UnsupportedOperationException eaten) {
                 // Let's make sure our graceful shutdown process doesn't cause failures.
             }
 
             try {
                 driver.switchTo().alert().dismiss();
-            } catch (WebDriverException e) { //NOSONAR
+            } catch (WebDriverException eaten) {
                 // The driver throws an exception if no alert is present. This is normal and unavoidable.
             }
 

src/main/java/com/nordstrom/automation/selenium/core/GridUtility.java

@@ -85,7 +85,7 @@ public static boolean isHostActive(final URL hostUrl, final String request) {
         try {
             HttpResponse response = getHttpResponse(hostUrl, request);
             return (response.getStatusLine().getStatusCode() == HttpStatus.SC_OK);
-        } catch (IOException e) { //NOSONAR
+        } catch (IOException eaten) {
             // nothing to do here
         }
         return false;
@@ -320,7 +320,7 @@ public static boolean isThisMyIpAddress(final InetAddress addr) {
         // Check if the address is defined on any interface
         try {
             return NetworkInterface.getByInetAddress(addr) != null;
-        } catch (SocketException e) { //NOSONAR
+        } catch (SocketException e) {
             LOGGER.warn("Attempt to associate IP address with adapter triggered I/O exception: {}", e.getMessage());
             return false;
         }

src/main/java/com/nordstrom/automation/selenium/core/LocalSeleniumGrid.java

@@ -86,7 +86,7 @@ public static SeleniumGrid create(SeleniumConfig config, final Path hubConfigPat
 
         String launcherClassName = config.getString(SeleniumSettings.GRID_LAUNCHER.key());
         String[] dependencyContexts = config.getDependencyContexts();
-        Integer hubPort = config.getInteger(SeleniumSettings.HUB_PORT.key(), Integer.valueOf(0));
+        Integer hubPort = config.getInteger(SeleniumSettings.HUB_PORT.key(), 0);
         String workingDir = config.getString(SeleniumSettings.GRID_WORKING_DIR.key());
         Path workingPath = (workingDir == null || workingDir.isEmpty()) ? null : Paths.get(workingDir);
         Path outputPath = GridUtility.getOutputPath(config, GridRole.HUB);
@@ -254,9 +254,9 @@ public static LocalGridServer create(final String launcherClassName, final Strin
 
         Integer portNum = port;
         // if port auto-select spec'd
-        if (portNum.intValue() == 0) {
+        if (portNum == 0) {
             // acquire available port
-            portNum = Integer.valueOf(PortProber.findFreePort());
+            portNum = PortProber.findFreePort();
         }
 
         // specify server port
@@ -299,8 +299,8 @@ public static LocalGridServer create(final String launcherClassName, final Strin
 
     public static class LocalGridServer extends GridServer {
 
-        private CommandLine process;
-        private Map<String, String> personalities = new HashMap<>();
+        private final CommandLine process;
+        private final Map<String, String> personalities = new HashMap<>();
 
         /**
          * Constructor for local Grid server object.

src/main/java/com/nordstrom/automation/selenium/examples/ExamplePage.java

@@ -236,7 +236,7 @@ public static URI setHubAsTarget() {
                     .setPort(hubUrl.getPort())
                     .build().normalize();
             config.setTargetUri(targetUri);
-        } catch (URISyntaxException e) {
+        } catch (URISyntaxException eaten) {
             // nothing to do here
         }
         return targetUri;

src/main/java/com/nordstrom/automation/selenium/examples/MacPage.java

@@ -0,0 +1,37 @@
+package com.nordstrom.automation.selenium.examples;
+
+import org.openqa.selenium.By;
+import org.openqa.selenium.WebDriver;
+
+import com.nordstrom.automation.selenium.model.Page;
+
+public class MacPage extends Page {
+
+    public MacPage(WebDriver driver) {
+        super(driver);
+    }
+    
+    protected enum Using implements ByEnum {
+        EDIT_FIELD(By.className("XCUIElementTypeTextView"));
+        
+        private By locator;
+        
+        Using(By locator) {
+            this.locator = locator;
+        }
+
+        @Override
+        public By locator() {
+            return locator;
+        }
+    }
+    
+    public void modifyDocument(String keys) {
+        findElement(Using.EDIT_FIELD).sendKeys(keys);
+    }
+    
+    public String accessDocument() {
+        return findElement(Using.EDIT_FIELD).getText();
+    }
+    
+}

src/main/java/com/nordstrom/automation/selenium/exceptions/ComponentStillDisplayedTimeoutException.java

@@ -8,7 +8,7 @@
  * This exception is associated with the {@link PageComponent#componentIsHidden()} condition and indicates that the
  * indicated page component was still displayed when the timeout interval expired.
  */
-public class ComponentStillDisplayedTimeoutException extends TimeoutException { //NOSONAR
+public class ComponentStillDisplayedTimeoutException extends TimeoutException {
 
     private static final long serialVersionUID = 5397614393701035129L;
 

src/main/java/com/nordstrom/automation/selenium/exceptions/ComponentStillInvisibleTimeoutException.java

@@ -8,7 +8,7 @@
  * This exception is associated with the {@link PageComponent#componentIsVisible()} condition and indicates that the
  * indicated page component was still invisible when the timeout interval expired.
  */
-public class ComponentStillInvisibleTimeoutException extends TimeoutException { //NOSONAR
+public class ComponentStillInvisibleTimeoutException extends TimeoutException {
 
     private static final long serialVersionUID = 7779370358344583623L;
 

src/main/java/com/nordstrom/automation/selenium/exceptions/ConditionStillInvalidTimeoutException.java

@@ -8,7 +8,7 @@
  * This exception is associated with the {@link Coordinators#has(com.google.common.base.Function)} wrapper method
  * and indicates that the wrapped condition was still returning a 'negative' result when the timeout interval expired. 
  */
-public class ConditionStillInvalidTimeoutException extends TimeoutException { //NOSONAR
+public class ConditionStillInvalidTimeoutException extends TimeoutException {
 
     private static final long serialVersionUID = -5012103332012897882L;
 

src/main/java/com/nordstrom/automation/selenium/exceptions/ConditionStillValidTimeoutException.java

@@ -8,7 +8,7 @@
  * This exception is associated with the {@link Coordinators#not(com.google.common.base.Function)} wrapper method
  * and indicates that the wrapped condition was still returning a 'positive' result when the timeout interval expired. 
  */
-public class ConditionStillValidTimeoutException extends TimeoutException { //NOSONAR
+public class ConditionStillValidTimeoutException extends TimeoutException {
 
     private static final long serialVersionUID = -1194280527172574112L;