Skip to content
This repository was archived by the owner on Nov 14, 2025. It is now read-only.

Commit 93c8ae3

Browse files
sapientpantsclaude
andauthored
fix: improve release job conditions to handle skipped dependencies (#326)
* fix: improve release job conditions to handle skipped dependencies Updated the create-release job condition to properly handle cases where docker and npm jobs are skipped instead of failing. The release will now proceed if build succeeded and docker/npm either succeeded or were skipped. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * chore: configure osv-scanner to ignore validator dev dependency issue Added osv-scanner.toml configuration to ignore GHSA-9965-vmph-33xx for the validator package since it's a dev-only dependency not exposed in production. The vulnerability is medium severity (CVSS 6.1) with no fix available yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * chore: add empty changeset for osv-scanner configuration This changeset is empty because the osv-scanner.toml configuration change is dev-only and does not require a release. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
1 parent 60d8f68 commit 93c8ae3

File tree

3 files changed

+20
-1
lines changed

3 files changed

+20
-1
lines changed

.changeset/fine-pianos-lead.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
---
2+
---

.github/workflows/main.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,12 @@ jobs:
273273
create-release:
274274
name: Create GitHub Release
275275
needs: [build, docker, npm]
276-
if: needs.build.outputs.changed == 'true'
276+
# Run if build succeeded AND docker/npm either succeeded or were skipped
277+
if: |
278+
needs.build.outputs.changed == 'true' &&
279+
!cancelled() &&
280+
(needs.docker.result == 'success' || needs.docker.result == 'skipped') &&
281+
(needs.npm.result == 'success' || needs.npm.result == 'skipped')
277282
runs-on: ubuntu-latest
278283
outputs:
279284
released: ${{ steps.release.outputs.released }}

osv-scanner.toml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
# OSV Scanner Configuration
2+
# Documentation: https://google.github.io/osv-scanner/configuration/
3+
4+
# Ignored vulnerabilities
5+
# These vulnerabilities are acknowledged and accepted as risk
6+
[[IgnoredVulns]]
7+
id = "GHSA-9965-vmph-33xx"
8+
# Reason: validator package is dev-only dependency (not in production)
9+
# Impact: Medium severity (CVSS 6.1)
10+
# Status: No fix available yet
11+
# Review date: 2025-10-14
12+
reason = "Dev-only dependency, not exposed in production"

0 commit comments

Comments
 (0)