Skip to content
This repository was archived by the owner on Nov 14, 2025. It is now read-only.

Commit 323854c

Browse files
authored
fix: use version in Docker artifact naming for consistency with NPM (#311)
Changed Docker artifact-name from 'docker-image-${{ github.sha }}' to 'docker-image-${{ needs.build.outputs.version }}' to match the NPM artifact naming pattern. This ensures consistent artifact naming across all artifact types: - NPM: npm-package-{VERSION}-{SHA} - Docker: docker-image-{VERSION}-{SHA} With consistent naming, determine-artifact.sh can use the same logic for both artifact types without conditional branches. Fixes the publish workflow failures where it couldn't find Docker artifacts because it was looking for docker-image-{VERSION}-{SHA} but the actual artifact was docker-image-{SHA}-{SHA}.
1 parent 2a326cb commit 323854c

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'sonarqube-mcp-server': patch
3+
---
4+
5+
Fix Docker artifact naming to match NPM pattern for consistent artifact resolution
6+
7+
Changed Docker artifact naming from `docker-image-{SHA}` to `docker-image-{VERSION}` to match the NPM artifact pattern. This ensures the determine-artifact.sh script can find Docker artifacts using the same logic as NPM artifacts, eliminating the need for conditional logic based on artifact type.

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ jobs:
188188
with:
189189
platforms: 'linux/amd64,linux/arm64'
190190
save-artifact: true
191-
artifact-name: 'docker-image-${{ github.sha }}'
191+
artifact-name: 'docker-image-${{ needs.build.outputs.version }}'
192192
image-name: 'sonarqube-mcp-server'
193193
version: ${{ needs.build.outputs.version }}
194194
tag_sha: ${{ github.sha }}

0 commit comments

Comments
 (0)