Skip to content

Commit 6058676

Browse files
author
Release Manager
committed
gh-41253: Restrict Cython's version and fix the uv building workflows
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes #12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes #12345". --> Relate to #41137, these two functions are only support on cython>=3.1.0 @tobiasdiez Can you help me upgrade uv lock file? I use conda but not uv. cython/cython@b684235 f7e096f6 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - #12345: short description why this is a dependency --> <!-- - #34567: ... --> URL: #41253 Reported by: Chenxin Zhong Reviewer(s): Tobias Diez
2 parents 80e63fc + 5be3896 commit 6058676

File tree

4 files changed

+11
-13
lines changed

4 files changed

+11
-13
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,10 @@ jobs:
5353
fi
5454
5555
- name: Checkout code
56-
# cannot use v4 yet because of https://github.com/actions/checkout/issues/1487
57-
uses: actions/checkout@v3
56+
uses: actions/checkout@v6.0.1
5857

5958
- name: Install uv
60-
uses: astral-sh/setup-uv@v6.7.0
59+
uses: astral-sh/setup-uv@v7.1.4
6160

6261
# We cannot use the setup python action because it doesn't support all containers
6362
# https://github.com/actions/setup-python/issues/527
@@ -95,8 +94,8 @@ jobs:
9594
uv pip install \
9695
meson-python \
9796
"cypari2 >=2.2.1" \
98-
"cysignals >=1.11.2, != 1.12.0" \
99-
"cython >=3.0, != 3.0.3, < 3.1.0" \
97+
"cysignals >=1.12.1" \
98+
"cython >=3.1.0" \
10099
"gmpy2 >=2.1.5" \
101100
memory_allocator \
102101
"numpy >=1.25" \

build/pkgs/configure/checksums.ini

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
tarball=configure-VERSION.tar.gz
2-
sha1=90e591299fb8d0abd1e286d4005892f8d75b287f
3-
sha256=8f67f1ebb4b1342c9b401af687db3df2467a81399c11619787957892f1588dcb
2+
sha1=15f24975477f68d9d018d7773b85a1a1e9ef8889
3+
sha256=4e60701ef332229d04ca9254c340bfee70ad313f3a9fc01bf136cbb45ceda66e
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
bd193409ca35ad695bb473d19751be0a16d9e32f
1+
3d5218bc716ca70a87ece1e5a9f00e5daefe9bac

pyproject.toml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,8 @@ requires = [
55
'cypari2 >=2.2.1; sys_platform != "win32"',
66
'meson-python',
77
# Exclude 1.12.0 because of https://github.com/sagemath/cysignals/issues/212
8-
'cysignals >=1.11.2, != 1.12.0',
9-
# Exclude 3.0.3 because of https://github.com/cython/cython/issues/5748
10-
'cython >=3.0, != 3.0.3',
8+
'cysignals >=1.12.1',
9+
'cython >=3.1.0',
1110
'gmpy2 >=2.1.5',
1211
'jinja2',
1312
'memory_allocator',
@@ -46,8 +45,8 @@ dependencies = [
4645
'cypari2 >=2.2.1; sys_platform != "win32"',
4746
'six >=1.15.0',
4847
# Exclude 1.12.0 because of https://github.com/sagemath/cysignals/issues/212
49-
'cysignals >=1.11.2, != 1.12.0',
50-
'cython >=3.0, != 3.0.3',
48+
'cysignals >=1.12.1',
49+
'cython >=3.1.0',
5150
'fpylll >=0.5.9; sys_platform != "win32"',
5251
'gmpy2 >=2.1.5',
5352
'ipykernel >=5.2.1',

0 commit comments

Comments
 (0)