feat: support nvim 0.11 winborder as popup.border (#163)

* feat: use global nvim option 'winborder' as popup border default

* feat: use 'winborder' only on nvim versions >= 0.11.0

* refactor(popup): Rewrite `popup.border` handling

and set the default config value to `nil`. Provide a utility function
that resolves the actual border value depending on the config value and
`neovim` version.

* docs: Regenerate documentation for `popup.border`

Author: har7an

doc/crates.txt

@@ -118,7 +118,7 @@ For more information about individual config options see |crates-config|.
             hide_on_select = false,
             copy_register = '"',
             style = "minimal",
-            border = "none",
+            border = nil,
             show_version_date = false,
             show_dependency_version = true,
             max_height = 30,
@@ -822,10 +822,13 @@ popup.style                                        *crates-config-popup-style*
 
 
 popup.border                                      *crates-config-popup-border*
-    Type: `string|string[]`, Default: `"none"`
+    Type: `string|string[]`, Default: `nil`
 
     Same as nvim_open_win config.border.
 
+    If unset or nil, defaults to global 'winborder' on nvim >= 0.11.0, else
+    "none".
+
 
 popup.show_version_date                *crates-config-popup-show_version_date*
     Type: `boolean`, Default: `false`

docgen/wiki/Documentation-unstable.md

@@ -276,7 +276,7 @@ require("crates").setup {
         hide_on_select = false,
         copy_register = '"',
         style = "minimal",
-        border = "none",
+        border = nil,
         show_version_date = false,
         show_dependency_version = true,
         max_height = 30,

lua/crates/config/init.lua

@@ -598,9 +598,12 @@ entry(schema_popup, {
         config_type = { "string", "table" },
         emmylua_annotation = "string|string[]",
     },
-    default = "none",
+    default = nil,
     description = [[
         Same as nvim_open_win config.border.
+
+        If unset or nil, defaults to global 'winborder' on nvim >= 0.11.0, else
+        "none".
     ]],
 })
 entry(schema_popup, {

lua/crates/popup/common.lua

@@ -165,6 +165,22 @@ function M.update_win(width, height, title, text, opts)
     vim.api.nvim_win_set_cursor(M.win, { l, 0 })
 end
 
+--- Get the border of the popup menu.
+---
+--- Returns the first valid value out of the following choices (in that order):
+--- 1. Config value `popup.border`, if configured
+--- 2. Global `winborder`, if neovim version >= 0.11.0
+--- 3. `"none"`
+local function popup_border()
+    if state.cfg.popup.border ~= nil then
+        return state.cfg.popup.border
+    elseif vim.version.ge(vim.version(), {0, 11, 0}) then
+        return vim.opt_global.winborder:get()
+    else
+        return "none"
+    end
+end
+
 ---@param width integer
 ---@param height integer
 ---@param title string
@@ -185,7 +201,7 @@ function M.open_win(width, height, title, text, opts, configure)
         width = width,
         height = height,
         style = state.cfg.popup.style,
-        border = state.cfg.popup.border,
+        border = popup_border(),
     })
 
     -- add key mappings