Simplify config parsing by creating parse_string_array function

Author: phil-opp

src/config.rs

@@ -76,34 +76,13 @@ fn read_config_inner(manifest_path: &Path) -> Result<Config> {
                 config.test_success_exit_code = Some(exit_code as i32);
             }
             ("run-command", Value::Array(array)) => {
-                let mut command = Vec::new();
-                for value in array {
-                    match value {
-                        Value::String(s) => command.push(s),
-                        _ => return Err(anyhow!("run-command must be a list of strings")),
-                    }
-                }
-                config.run_command = Some(command);
+                config.run_command = Some(parse_string_array(array, "run-command")?);
             }
             ("run-args", Value::Array(array)) => {
-                let mut args = Vec::new();
-                for value in array {
-                    match value {
-                        Value::String(s) => args.push(s),
-                        _ => return Err(anyhow!("run-args must be a list of strings")),
-                    }
-                }
-                config.run_args = Some(args);
+                config.run_args = Some(parse_string_array(array, "run-args")?);
             }
             ("test-args", Value::Array(array)) => {
-                let mut args = Vec::new();
-                for value in array {
-                    match value {
-                        Value::String(s) => args.push(s),
-                        _ => return Err(anyhow!("test-args must be a list of strings")),
-                    }
-                }
-                config.test_args = Some(args);
+                config.test_args = Some(parse_string_array(array, "test-args")?);
             }
             (key, value) => {
                 return Err(anyhow!(
@@ -118,6 +97,17 @@ fn read_config_inner(manifest_path: &Path) -> Result<Config> {
     Ok(config.into())
 }
 
+fn parse_string_array(array: Vec<Value>, prop_name: &str) -> Result<Vec<String>> {
+    let mut parsed = Vec::new();
+    for value in array {
+        match value {
+            Value::String(s) => parsed.push(s),
+            _ => return Err(anyhow!("{} must be a list of strings", prop_name)),
+        }
+    }
+    Ok(parsed)
+}
+
 #[derive(Default)]
 struct ConfigBuilder {
     run_command: Option<Vec<String>>,