Rollup merge of #145041 - lcnr:borrowck-limitations-error, r=BoxyUwU

rework GAT borrowck limitation error

The old one depends on the `ConstraintCategory` of the constraint which meant we did not emit this note if we had to prove the higher ranked trait bound due to e.g. normalization.

This made it annoying brittle and caused MIR borrowck errors to be order dependent, fixes the issue in rust-lang/rust#140737 (comment).

r? types cc ```@amandasystems```

Author: Zalathar