Fix verbosity setting

Author: Shourya742

src/bootstrap/src/core/config/config.rs

@@ -93,7 +93,6 @@ pub struct Config {
     pub ccache: Option<String>,
     /// Call Build::ninja() instead of this.
     pub ninja_in_file: bool,
-    pub verbose: usize,
     pub submodules: Option<bool>,
     pub compiler_docs: bool,
     pub library_docs_private_items: bool,
@@ -528,7 +527,7 @@ impl Config {
             extended,
             tools,
             tool,
-            verbose,
+            verbose: build_verbose,
             sanitizers,
             profiler,
             cargo_native_static,
@@ -586,6 +585,12 @@ impl Config {
             }
         }
 
+        // Prefer CLI verbosity flags if set (`flags_verbose` > 0), otherwise take the value from
+        // TOML.
+        config
+            .exec_ctx
+            .set_verbosity(cmp::max(build_verbose.unwrap_or_default() as u8, flags_verbose));
+
         let mut paths: Vec<PathBuf> = flags_skip.into_iter().chain(flags_exclude).collect();
         if let Some(exclude) = exclude {
             paths.extend(exclude);
@@ -741,7 +746,6 @@ impl Config {
         set(&mut config.extended, extended);
         config.tools = tools;
         set(&mut config.tool, tool);
-        set(&mut config.verbose, verbose);
         set(&mut config.sanitizers, sanitizers);
         set(&mut config.profiler, profiler);
         set(&mut config.cargo_native_static, cargo_native_static);
@@ -750,8 +754,6 @@ impl Config {
         set(&mut config.print_step_timings, print_step_timings);
         set(&mut config.print_step_rusage, print_step_rusage);
 
-        config.verbose = cmp::max(config.verbose, flags_verbose as usize);
-
         // Verbose flag is a good default for `rust.verbose-tests`.
         config.verbose_tests = config.is_verbose();
 

src/bootstrap/src/lib.rs

@@ -515,7 +515,7 @@ impl Build {
             local_rebuild: config.local_rebuild,
             fail_fast: config.cmd.fail_fast(),
             doc_tests: config.cmd.doc_tests(),
-            verbosity: config.verbose,
+            verbosity: config.exec_ctx.verbosity as usize,
 
             host_target: config.host_target,
             hosts: config.hosts.clone(),

src/bootstrap/src/utils/exec.rs

@@ -550,7 +550,7 @@ impl Default for CommandOutput {
 #[derive(Clone, Default)]
 pub struct ExecutionContext {
     dry_run: DryRun,
-    verbosity: u8,
+    pub verbosity: u8,
     pub fail_fast: bool,
     delayed_failures: Arc<Mutex<Vec<String>>>,
     command_cache: Arc<CommandCache>,
@@ -640,7 +640,7 @@ impl ExecutionContext {
         self.dry_run = value;
     }
 
-    pub fn set_verbose(&mut self, value: u8) {
+    pub fn set_verbosity(&mut self, value: u8) {
         self.verbosity = value;
     }