Auto merge of #14269 - epage:test-ext, r=ehuss

fix(test)!: Clarify extension trait role with rename

When browsing the docs, I feel like this will make it easier to tell the role of these traits within the API.
Or in other words, I can easily tell that these fill a support role and for what, so I know when I care to look into them.

We use this naming pattern for
`cargo_test_support::paths::CargoPathExt`.

Author: bors

crates/cargo-test-support/src/lib.rs

@@ -76,10 +76,10 @@ pub mod tools;
 pub mod prelude {
     pub use crate::cargo_test;
     pub use crate::paths::CargoPathExt;
-    pub use crate::ArgLine;
-    pub use crate::CargoCommand;
-    pub use crate::ChannelChanger;
-    pub use crate::TestEnv;
+    pub use crate::ArgLineCommandExt;
+    pub use crate::CargoCommandExt;
+    pub use crate::ChannelChangerCommandExt;
+    pub use crate::TestEnvCommandExt;
     pub use snapbox::IntoData;
 }
 
@@ -1248,27 +1248,27 @@ fn _process(t: &OsStr) -> ProcessBuilder {
 }
 
 /// Enable nightly features for testing
-pub trait ChannelChanger {
+pub trait ChannelChangerCommandExt {
     /// The list of reasons should be why nightly cargo is needed. If it is
     /// because of an unstable feature put the name of the feature as the reason,
     /// e.g. `&["print-im-a-teapot"]`.
     fn masquerade_as_nightly_cargo(self, _reasons: &[&str]) -> Self;
 }
 
-impl ChannelChanger for &mut ProcessBuilder {
+impl ChannelChangerCommandExt for &mut ProcessBuilder {
     fn masquerade_as_nightly_cargo(self, _reasons: &[&str]) -> Self {
         self.env("__CARGO_TEST_CHANNEL_OVERRIDE_DO_NOT_USE_THIS", "nightly")
     }
 }
 
-impl ChannelChanger for snapbox::cmd::Command {
+impl ChannelChangerCommandExt for snapbox::cmd::Command {
     fn masquerade_as_nightly_cargo(self, _reasons: &[&str]) -> Self {
         self.env("__CARGO_TEST_CHANNEL_OVERRIDE_DO_NOT_USE_THIS", "nightly")
     }
 }
 
 /// Establish a process's test environment
-pub trait TestEnv: Sized {
+pub trait TestEnvCommandExt: Sized {
     fn test_env(mut self) -> Self {
         // In general just clear out all cargo-specific configuration already in the
         // environment. Our tests all assume a "default configuration" unless
@@ -1358,7 +1358,7 @@ pub trait TestEnv: Sized {
     fn env_remove(self, key: &str) -> Self;
 }
 
-impl TestEnv for &mut ProcessBuilder {
+impl TestEnvCommandExt for &mut ProcessBuilder {
     fn current_dir<S: AsRef<std::path::Path>>(self, path: S) -> Self {
         let path = path.as_ref();
         self.cwd(path)
@@ -1371,7 +1371,7 @@ impl TestEnv for &mut ProcessBuilder {
     }
 }
 
-impl TestEnv for snapbox::cmd::Command {
+impl TestEnvCommandExt for snapbox::cmd::Command {
     fn current_dir<S: AsRef<std::path::Path>>(self, path: S) -> Self {
         self.current_dir(path)
     }
@@ -1384,11 +1384,11 @@ impl TestEnv for snapbox::cmd::Command {
 }
 
 /// Test the cargo command
-pub trait CargoCommand {
+pub trait CargoCommandExt {
     fn cargo_ui() -> Self;
 }
 
-impl CargoCommand for snapbox::cmd::Command {
+impl CargoCommandExt for snapbox::cmd::Command {
     fn cargo_ui() -> Self {
         Self::new(cargo_exe())
             .with_assert(compare::assert_ui())
@@ -1398,7 +1398,7 @@ impl CargoCommand for snapbox::cmd::Command {
 }
 
 /// Add a list of arguments as a line
-pub trait ArgLine: Sized {
+pub trait ArgLineCommandExt: Sized {
     fn arg_line(mut self, s: &str) -> Self {
         for mut arg in s.split_whitespace() {
             if (arg.starts_with('"') && arg.ends_with('"'))
@@ -1416,13 +1416,13 @@ pub trait ArgLine: Sized {
     fn arg<S: AsRef<std::ffi::OsStr>>(self, s: S) -> Self;
 }
 
-impl ArgLine for &mut ProcessBuilder {
+impl ArgLineCommandExt for &mut ProcessBuilder {
     fn arg<S: AsRef<std::ffi::OsStr>>(self, s: S) -> Self {
         self.arg(s)
     }
 }
 
-impl ArgLine for snapbox::cmd::Command {
+impl ArgLineCommandExt for snapbox::cmd::Command {
     fn arg<S: AsRef<std::ffi::OsStr>>(self, s: S) -> Self {
         self.arg(s)
     }

tests/testsuite/cargo_bench/no_keep_going/mod.rs

@@ -2,7 +2,7 @@ use cargo_test_support::current_dir;
 use cargo_test_support::file;
 use cargo_test_support::prelude::*;
 use cargo_test_support::str;
-use cargo_test_support::CargoCommand;
+use cargo_test_support::CargoCommandExt;
 use cargo_test_support::Project;
 
 #[cargo_test]

tests/testsuite/cargo_init/inherit_workspace_package_table/mod.rs

@@ -3,7 +3,7 @@ use cargo_test_support::current_dir;
 use cargo_test_support::file;
 use cargo_test_support::prelude::*;
 use cargo_test_support::str;
-use cargo_test_support::CargoCommand;
+use cargo_test_support::CargoCommandExt;
 use cargo_test_support::Project;
 
 #[cargo_test]

tests/testsuite/cargo_new/add_members_to_non_workspace/mod.rs

@@ -3,7 +3,7 @@ use cargo_test_support::current_dir;
 use cargo_test_support::file;
 use cargo_test_support::prelude::*;
 use cargo_test_support::str;
-use cargo_test_support::CargoCommand;
+use cargo_test_support::CargoCommandExt;
 use cargo_test_support::Project;
 
 #[cargo_test]

tests/testsuite/cargo_new/add_members_to_workspace_format_previous_items/mod.rs

@@ -3,7 +3,7 @@ use cargo_test_support::current_dir;
 use cargo_test_support::file;
 use cargo_test_support::prelude::*;
 use cargo_test_support::str;
-use cargo_test_support::CargoCommand;
+use cargo_test_support::CargoCommandExt;
 use cargo_test_support::Project;
 
 #[cargo_test]

tests/testsuite/cargo_new/add_members_to_workspace_format_sorted/mod.rs

@@ -3,7 +3,7 @@ use cargo_test_support::current_dir;
 use cargo_test_support::file;
 use cargo_test_support::prelude::*;
 use cargo_test_support::str;
-use cargo_test_support::CargoCommand;
+use cargo_test_support::CargoCommandExt;
 use cargo_test_support::Project;
 
 #[cargo_test]

tests/testsuite/cargo_new/add_members_to_workspace_with_absolute_package_path/mod.rs

@@ -3,7 +3,7 @@ use cargo_test_support::current_dir;
 use cargo_test_support::file;
 use cargo_test_support::prelude::*;
 use cargo_test_support::str;
-use cargo_test_support::CargoCommand;
+use cargo_test_support::CargoCommandExt;
 use cargo_test_support::Project;
 
 #[cargo_test]

tests/testsuite/cargo_new/add_members_to_workspace_with_empty_members/mod.rs

@@ -3,7 +3,7 @@ use cargo_test_support::current_dir;
 use cargo_test_support::file;
 use cargo_test_support::prelude::*;
 use cargo_test_support::str;
-use cargo_test_support::CargoCommand;
+use cargo_test_support::CargoCommandExt;
 use cargo_test_support::Project;
 
 #[cargo_test]

tests/testsuite/cargo_new/add_members_to_workspace_with_exclude_list/mod.rs

@@ -3,7 +3,7 @@ use cargo_test_support::current_dir;
 use cargo_test_support::file;
 use cargo_test_support::prelude::*;
 use cargo_test_support::str;
-use cargo_test_support::CargoCommand;
+use cargo_test_support::CargoCommandExt;
 use cargo_test_support::Project;
 
 #[cargo_test]

tests/testsuite/cargo_new/add_members_to_workspace_with_members_glob/mod.rs

@@ -3,7 +3,7 @@ use cargo_test_support::current_dir;
 use cargo_test_support::file;
 use cargo_test_support::prelude::*;
 use cargo_test_support::str;
-use cargo_test_support::CargoCommand;
+use cargo_test_support::CargoCommandExt;
 use cargo_test_support::Project;
 
 #[cargo_test]