refactor(lints): move lints definitions to a rules module

Author: weihanglo

src/cargo/core/workspace.rs

@@ -21,9 +21,9 @@ use crate::core::{
 };
 use crate::core::{EitherManifest, Package, SourceId, VirtualManifest};
 use crate::lints::analyze_cargo_lints_table;
-use crate::lints::blanket_hint_mostly_unused;
-use crate::lints::check_im_a_teapot;
-use crate::lints::implicit_minimum_version_req;
+use crate::lints::rules::blanket_hint_mostly_unused;
+use crate::lints::rules::check_im_a_teapot;
+use crate::lints::rules::implicit_minimum_version_req;
 use crate::ops;
 use crate::sources::{CRATES_IO_INDEX, CRATES_IO_REGISTRY, PathSource, SourceConfigMap};
 use crate::util::context::FeatureUnification;

src/cargo/lints/mod.rs

@@ -13,22 +13,10 @@ use std::fmt::Display;
 use std::ops::Range;
 use std::path::Path;
 
-mod blanket_hint_mostly_unused;
-pub use blanket_hint_mostly_unused::blanket_hint_mostly_unused;
-mod implicit_minimum_version_req;
-pub use implicit_minimum_version_req::implicit_minimum_version_req;
-mod im_a_teapot;
-pub use im_a_teapot::check_im_a_teapot;
-mod unknown_lints;
-use unknown_lints::output_unknown_lints;
+pub mod rules;
+pub use rules::LINTS;
 
 const LINT_GROUPS: &[LintGroup] = &[TEST_DUMMY_UNSTABLE];
-pub const LINTS: &[Lint] = &[
-    blanket_hint_mostly_unused::LINT,
-    implicit_minimum_version_req::LINT,
-    im_a_teapot::LINT,
-    unknown_lints::LINT,
-];
 
 /// Scope at which a lint runs: package-level or workspace-level.
 pub enum ManifestFor<'a> {
@@ -129,7 +117,7 @@ pub fn analyze_cargo_lints_table(
         }
     }
 
-    output_unknown_lints(
+    rules::output_unknown_lints(
         unknown_lints,
         &manifest,
         &manifest_path,
@@ -506,7 +494,7 @@ mod tests {
 
     #[test]
     fn ensure_updated_lints() {
-        let dir = snapbox::utils::current_dir!();
+        let dir = snapbox::utils::current_dir!().join("rules");
         let mut expected = HashSet::new();
         for entry in std::fs::read_dir(&dir).unwrap() {
             let entry = entry.unwrap();

…argo/lints/blanket_hint_mostly_unused.rs …ints/rules/blanket_hint_mostly_unused.rssrc/cargo/lints/blanket_hint_mostly_unused.rs renamed to src/cargo/lints/rules/blanket_hint_mostly_unused.rs src/cargo/lints/blanket_hint_mostly_unused.rs renamed to src/cargo/lints/rules/blanket_hint_mostly_unused.rs

@@ -0,0 +1,16 @@
+mod blanket_hint_mostly_unused;
+mod im_a_teapot;
+mod implicit_minimum_version_req;
+mod unknown_lints;
+
+pub use blanket_hint_mostly_unused::blanket_hint_mostly_unused;
+pub use im_a_teapot::check_im_a_teapot;
+pub use implicit_minimum_version_req::implicit_minimum_version_req;
+pub use unknown_lints::output_unknown_lints;
+
+pub const LINTS: &[crate::lints::Lint] = &[
+    blanket_hint_mostly_unused::LINT,
+    implicit_minimum_version_req::LINT,
+    im_a_teapot::LINT,
+    unknown_lints::LINT,
+];