ide-diagnostics: Fix warnings about clippy str_to_string rule

Author: tetsuharuohzeki

crates/ide-diagnostics/src/handlers/inactive_code.rs

@@ -16,7 +16,7 @@ pub(crate) fn inactive_code(
     }
 
     let inactive = DnfExpr::new(d.cfg.clone()).why_inactive(&d.opts);
-    let mut message = "code is inactive due to #[cfg] directives".to_string();
+    let mut message = "code is inactive due to #[cfg] directives".to_owned();
 
     if let Some(inactive) = inactive {
         let inactive_reasons = inactive.to_string();

crates/ide-diagnostics/src/handlers/incoherent_impl.rs

@@ -9,7 +9,7 @@ pub(crate) fn incoherent_impl(ctx: &DiagnosticsContext<'_>, d: &hir::IncoherentI
     Diagnostic::new_with_syntax_node_ptr(
         ctx,
         DiagnosticCode::RustcHardError("E0210"),
-        "cannot define inherent `impl` for foreign type".to_string(),
+        "cannot define inherent `impl` for foreign type".to_owned(),
         InFile::new(d.file_id, d.impl_.into()),
     )
 }

crates/ide-diagnostics/src/handlers/incorrect_case.rs

@@ -512,7 +512,7 @@ impl BAD_TRAIT for () {
     fn BadFunction() {}
 }
     "#,
-            std::iter::once("unused_variables".to_string()),
+            std::iter::once("unused_variables".to_owned()),
         );
     }
 

crates/ide-diagnostics/src/handlers/json_is_not_rust.rs

@@ -42,12 +42,12 @@ impl State {
             v.push("Deserialize");
         }
         match v.as_slice() {
-            [] => "".to_string(),
+            [] => "".to_owned(),
             [x] => format!("#[derive({x})]\n"),
             [x, y] => format!("#[derive({x}, {y})]\n"),
             _ => {
                 never!();
-                "".to_string()
+                "".to_owned()
             }
         }
     }
@@ -176,7 +176,7 @@ mod tests {
     #[test]
     fn diagnostic_for_simple_case() {
         let mut config = DiagnosticsConfig::test_sample();
-        config.disabled.insert("syntax-error".to_string());
+        config.disabled.insert("syntax-error".to_owned());
         check_diagnostics_with_config(
             config,
             r#"

crates/ide-diagnostics/src/handlers/macro_error.rs

@@ -99,7 +99,7 @@ pub macro panic {
 
         // FIXME: This is a false-positive, the file is actually linked in via
         // `include!` macro
-        config.disabled.insert("unlinked-file".to_string());
+        config.disabled.insert("unlinked-file".to_owned());
 
         check_diagnostics_with_config(
             config,
@@ -268,8 +268,8 @@ fn f() {
     #[test]
     fn include_does_not_break_diagnostics() {
         let mut config = DiagnosticsConfig::test_sample();
-        config.disabled.insert("inactive-code".to_string());
-        config.disabled.insert("unlinked-file".to_string());
+        config.disabled.insert("inactive-code".to_owned());
+        config.disabled.insert("unlinked-file".to_owned());
         check_diagnostics_with_config(
             config,
             r#"

crates/ide-diagnostics/src/handlers/missing_fields.rs

@@ -170,7 +170,7 @@ fn make_ty(ty: &hir::Type, db: &dyn HirDatabase, module: hir::Module) -> ast::Ty
     let ty_str = match ty.as_adt() {
         Some(adt) => adt.name(db).display(db.upcast()).to_string(),
         None => {
-            ty.display_source_code(db, module.into(), false).ok().unwrap_or_else(|| "_".to_string())
+            ty.display_source_code(db, module.into(), false).ok().unwrap_or_else(|| "_".to_owned())
         }
     };
 

crates/ide-diagnostics/src/handlers/missing_match_arms.rs

@@ -31,7 +31,7 @@ mod tests {
     #[test]
     fn empty_body() {
         let mut config = DiagnosticsConfig::test_sample();
-        config.disabled.insert("syntax-error".to_string());
+        config.disabled.insert("syntax-error".to_owned());
         check_diagnostics_with_config(
             config,
             r#"

crates/ide-diagnostics/src/handlers/mutability_errors.rs

@@ -19,7 +19,7 @@ pub(crate) fn need_mut(ctx: &DiagnosticsContext<'_>, d: &hir::NeedMut) -> Diagno
         for source in d.local.sources(ctx.sema.db) {
             let Some(ast) = source.name() else { continue };
             // FIXME: macros
-            edit_builder.insert(ast.value.syntax().text_range().start(), "mut ".to_string());
+            edit_builder.insert(ast.value.syntax().text_range().start(), "mut ".to_owned());
         }
         let edit = edit_builder.finish();
         Some(vec![fix(
@@ -448,7 +448,7 @@ fn main(b: bool) {
     &mut x;
 }
 "#,
-            std::iter::once("remove-unnecessary-else".to_string()),
+            std::iter::once("remove-unnecessary-else".to_owned()),
         );
         check_diagnostics_with_disabled(
             r#"
@@ -463,7 +463,7 @@ fn main(b: bool) {
     &mut x;
 }
 "#,
-            std::iter::once("remove-unnecessary-else".to_string()),
+            std::iter::once("remove-unnecessary-else".to_owned()),
         );
     }
 

crates/ide-diagnostics/src/handlers/remove_trailing_return.rs

@@ -140,7 +140,7 @@ fn foo(x: usize) -> u8 {
     } //^^^^^^^^^ 💡 weak: replace return <expr>; with <expr>
 }
 "#,
-            std::iter::once("remove-unnecessary-else".to_string()),
+            std::iter::once("remove-unnecessary-else".to_owned()),
         );
     }
 
@@ -309,7 +309,7 @@ fn foo(x: usize) -> u8 {
     }
 }
 "#,
-            std::iter::once("remove-unnecessary-else".to_string()),
+            std::iter::once("remove-unnecessary-else".to_owned()),
         );
         check_fix(
             r#"

crates/ide-diagnostics/src/handlers/remove_unnecessary_else.rs

@@ -90,7 +90,7 @@ mod tests {
     use crate::tests::{check_diagnostics, check_diagnostics_with_disabled, check_fix};
 
     fn check_diagnostics_with_needless_return_disabled(ra_fixture: &str) {
-        check_diagnostics_with_disabled(ra_fixture, std::iter::once("needless_return".to_string()));
+        check_diagnostics_with_disabled(ra_fixture, std::iter::once("needless_return".to_owned()));
     }
 
     #[test]