Remove casts from FullInt impl

Michael Wright · Michael Wright · commit c8edd9a16e2e · 2021-10-30T06:22:19.000+02:00
diff --git a/clippy_utils/src/consts.rs b/clippy_utils/src/consts.rs
@@ -230,16 +230,9 @@ pub enum FullInt {
 }
 
 impl FullInt {
-    #[allow(clippy::cast_sign_loss)]
     #[must_use]
     fn cmp_s_u(s: i128, u: u128) -> Ordering {
-        if s < 0 {
-            Ordering::Less
-        } else if u > (i128::MAX as u128) {
-            Ordering::Greater
-        } else {
-            (s as u128).cmp(&u)
-        }
+        u128::try_from(s).map_or(Ordering::Less, |x| x.cmp(&u))
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -230,16 +230,9 @@ pub enum FullInt {`
`230`	`230`	`}`
`231`	`231`
`232`	`232`	`impl FullInt {`
`233`		`- #[allow(clippy::cast_sign_loss)]`
`234`	`233`	`#[must_use]`
`235`	`234`	`fn cmp_s_u(s: i128, u: u128) -> Ordering {`
`236`		`- if s < 0 {`
`237`		`- Ordering::Less`
`238`		`- } else if u > (i128::MAX as u128) {`
`239`		`- Ordering::Greater`
`240`		`- } else {`
`241`		`- (s as u128).cmp(&u)`
`242`		`- }`
	`235`	`+ u128::try_from(s).map_or(Ordering::Less, \|x\| x.cmp(&u))`
`243`	`236`	`}`
`244`	`237`	`}`
`245`	`238`