Add function pointer casts #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes compiler warning added to nightly recently. People often accidentally cast function pointers to integers when they meant to call the function and cast the result, but they forgot the (). So because we actually want to cast a function pointer we have to be clear about that.
thejpster
force-pushed
the
pointer-casts
branch
from
5de7b05 to
507791d
Compare
jannic
approved these changes
Dec 3, 2025
Member
jannic
left a comment
jannic
left a comment
There was a problem hiding this comment.
At first I was a bit surprised that the warning emitted by rustc is different from what you added:
help: first cast to a pointer `as *const ()`
|
71 | addr, bkpt_from_a32 as *const () as usize
| ++++++++++++
However then I read the comments on the PR introducing this lint, and realized that *const () is just a compromise.
The original author of the lint actually preferred the variant you chose. rust-lang/rust#141470 (comment)
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be explicit about pointer casts
Current nightly Rust now warns about function pointer casts
Bump nightly Rust compiler version for tests/examples