Skip to content

Add simplifications for plausible custom overflow criteria #866

@jberthold

Description

@jberthold

The current program cannot currently be proven by kmir:

pub fn check_checked_add(u1: u64, u2: u64) {
   let result = u1.checked_add(u2);
   if u64::MAX - u2 < u1 {
       assert!(result.is_none());
   } else {
       assert!(result.is_some());
   }
}

The reason is that the overflow criterion used for checked_add is (u1 + u2) & (2^64 - 1) == u1 + u2, and the SMT solver cannot conclude that in this case (2^64 - 1) - u2 < u1 is false.
While the criterion u1.checked_add(u2).is_none() can be used instead in the use case where this comes from, a few suitable lemmas should be added to cover the MAX - .. subtraction way , and other plausible non-standard ways, to check for overflows.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions