avm1: add Value::as_xml_node convenience method

This avoids having to call `coerce_to_object`

Author: moulins

core/src/avm1/globals/xml_node.rs

@@ -69,8 +69,7 @@ fn append_child<'gc>(
 ) -> Result<Value<'gc>, Error<'gc>> {
     if let (Some(xmlnode), Some(child_xmlnode)) = (
         this.as_xml_node(),
-        args.get(0)
-            .and_then(|n| n.coerce_to_object(activation).as_xml_node()),
+        args.get(0).and_then(|n| n.as_xml_node()),
     ) {
         if !xmlnode.has_child(child_xmlnode) {
             let position = xmlnode.children_len();
@@ -89,10 +88,8 @@ fn insert_before<'gc>(
 ) -> Result<Value<'gc>, Error<'gc>> {
     if let (Some(xmlnode), Some(child_xmlnode), Some(insertpoint_xmlnode)) = (
         this.as_xml_node(),
-        args.get(0)
-            .and_then(|n| n.coerce_to_object(activation).as_xml_node()),
-        args.get(1)
-            .and_then(|n| n.coerce_to_object(activation).as_xml_node()),
+        args.get(0).and_then(|n| n.as_xml_node()),
+        args.get(1).and_then(|n| n.as_xml_node()),
     ) {
         if !xmlnode.has_child(child_xmlnode) {
             if let Some(position) = xmlnode.child_position(insertpoint_xmlnode) {

core/src/avm1/value.rs

@@ -508,6 +508,14 @@ impl<'gc> Value<'gc> {
             Value::Bool(_) | Value::Object(_) | Value::MovieClip(_) => None,
         }
     }
+
+    /// Get the underlying XML node for this value, if it exists.
+    pub fn as_xml_node(self) -> Option<crate::avm1::xml::XmlNode<'gc>> {
+        match self {
+            Value::Object(obj) => obj.as_xml_node(),
+            _ => None,
+        }
+    }
 }
 
 /// Calculate `value * 10^exp` through repeated multiplication or division.